CiviCRM Community Forums (archive)

hmm - why is there reference to ajax in this?

civicrm_api/crmAPI/ajax

we're not talking about REST only stuff are we?

To be honest I'm most inclined just to remove the & before params on create and / or to edit the functions so that they construct a $values off the params (which some do).

I suppose I just haven't fully 'got with' the new way of doing stuff yet & am still thinking v2 + standardisation new a whole new generation of API

Hi,

Let's leave the api as compatible as possible (ie. not a lot). Whatever was doing the create is mostly good enough, and if the create with an id in param was happily replacing the existing fields with empty ones, so be it (let's hide all the issues about &$params and say that's for compatibility reasons

For v3, let's decide that the preferred way is to call the api (php version)

civicrm_api (entity,action,param)

and the preferred way for the ajax is
/civicrm/ajax/rest?entity=xx&action=yyy (instead of fnName=civicrm_entity_action)

And we introduce a new action "update", that doesn't have any civicrm_entity_update, but does your magic of fetching the existing data with a civicrm_entity_get, merge the arrays and call civicrm_entity_create

This can sit in the civicrm_api only. We solved the &$params, didn't change anything on the existing functions and introduced a new action on 30+ entities with a handful of lines of code

X+

Hi,

was looking at some code of "update or create".

That was on v2:

$paramsSearch = array (search criterias);
$params = array (stuff I want to save);

$result = civicrm_contact_get ($paramsSearch);
if (!$result[is_error]) {
  $params [contact_id] = $result[I never know what to put sequential I miss you][contact_id];
}
civicrm_contact_ create ($params);

With the v3:

$action= 'create';
$paramsSearch = array (search criterias, sequential => 1);
$params = array (stuff I want to save);

$result = civicrm_api ('contact','get', $paramsSearch);
if (!$result[is_error]) {
  $params [contact_id] = $result[0][contact_id]; // we know that 0 is the first one, no matter its id
  $action= 'update';
}
civicrm('contact',$action,$params);

I'd argue that it doesn't add a lot of lines and I'd go as far as saying that's clearer that you modify. Got a use case where it would be more complicated to set the $action string ?

can you explain why we need 'createOnFail'

seems like a crude hack. if an id is passed in which is invalid, most of the times something is wrong higher up the chain

lobo

I've implemented civicrm_api (entity,'modify',$param) that

(entity,get), merge the param and what's in the db, and (entity,create)

The issue so far is that the id is sometimes id, sometimes entity_id, sometimes id, and some returns have a different format.

I'm taking the convention that id is the name of the id. I suppose we need to modify the create & get apis to be sure the id is always id.

Let me know if you have a better id(ea)
X+