CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication
Pages: 1 [2]

Author Topic: CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication  (Read 9963 times)

lolas

  • I post frequently
  • ***
  • Posts: 134
  • Karma: 9
    • Freeform Solutions
  • CiviCRM version: Several
  • CMS version: Drupal
  • MySQL version: 5.1+
  • PHP version: Several
Re: CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication
March 25, 2014, 03:32:31 pm
Quote from: podfish on May 19, 2013, 07:05:58 pm
Confirm:  Commenting out
Code: [Select]
($this->_esmtp['STARTTLS'] == true) && unborks amazon's SES.  I am new here, but it really looks like this is a patch that keeps getting reapplied which attempts to repeat the same thing the isset() function above it which works JUST FINE all by itself.  Should I submit a bug, or is this going to break something in older pear/php versions?

The Podfish

As far as I can tell we just recently had to use this fix to connect to smtp.office365.com on port 587. We didn't find any other combination that worked.
Freeform Solutions provides technology and management consulting, website and database development, and managed internet hosting solutions for not-for-profit organizations (NFPs).

ken

  • I live on this forum
  • *****
  • Posts: 916
  • Karma: 53
    • City Bible Forum
  • CiviCRM version: 4.6.3
  • CMS version: Drupal 7.36
  • MySQL version: 5.5.41
  • PHP version: 5.3.10
Re: CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication
March 26, 2014, 05:21:38 pm
Here's my original patch, updated for 4.4.2.
Code: [Select]
--- /data/Download/CiviCRM/civicrm-4.4.2-drupal/./packages/Net/SMTP.php 2013-11-21 16:10:14.000000000 +1100
+++ /data/Work/IT/CiviCRM/Local/4.4.2/civicrm/./packages/Net/SMTP.php 2013-11-22 23:11:04.930766807 +1100
@@ -601,8 +601,6 @@
          * (SSL) socket connection. */
         if ($tls && version_compare(PHP_VERSION, '5.1.0', '>=') &&
             extension_loaded('openssl') && isset($this->_esmtp['STARTTLS']) &&
-            // CiviCRM: CRM-8744
-            ($this->_esmtp['STARTTLS'] == true) &&
             strncasecmp($this->host, 'ssl://', 6) !== 0) {
             /* Start the TLS connection attempt. */
             if (PEAR::isError($result = $this->_put('STARTTLS'))) {
I just repatch the code after each release.

ken

  • I live on this forum
  • *****
  • Posts: 916
  • Karma: 53
    • City Bible Forum
  • CiviCRM version: 4.6.3
  • CMS version: Drupal 7.36
  • MySQL version: 5.5.41
  • PHP version: 5.3.10
Re: CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication
March 26, 2014, 05:40:36 pm
Dear core team,

Can we please reverse the patch made in CRM-8744?
  • It's causing a number of us issues
  • The latest version of http://pear.php.net/package/Net_SMTP doesn't include this patch (released 2013-07-05) which tells me it's not an important patch
  • The source of the patch http://www.pear-forum.org/post-4935.html has gone off-air so we can't see why this patch was made or assess how well it was tested etc
  • I can demonstrate (in a previous reply) that this patch breaks the code
  • This patch creates a security issue, because it forces people to authenticate SMTP in the clear
Thanks,

Ken

ken

  • I live on this forum
  • *****
  • Posts: 916
  • Karma: 53
    • City Bible Forum
  • CiviCRM version: 4.6.3
  • CMS version: Drupal 7.36
  • MySQL version: 5.5.41
  • PHP version: 5.3.10
Re: CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication
June 07, 2014, 07:18:16 am
See issue https://issues.civicrm.org/jira/browse/CRM-14814

See PR https://github.com/civicrm/civicrm-packages/pull/66

zkrebs

  • I post occasionally
  • **
  • Posts: 69
  • Karma: 1
Re: CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication
January 23, 2015, 05:35:11 pm
I just upgraded my 3.x to 4.3.x on Drupal 6 and I applied the patch at http://forum.civicrm.org/index.php/topic,21960.msg97008.html#msg97008 and it worked for me
Pages: 1 [2]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Core CiviCRM Functions (Moderator: Yashodha Chaku) »
  • CRM-8744 breaks sending emails to SMTP servers requiring TLS & authentication

This forum was archived on 2017-11-26.