CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion »
  • Sprints »
  • Sprints @ CiviCon 2012 »
  • San Francisco Code Sprints - March 29-30 and April 4-12, 2012
Pages: 1 [2]

Author Topic: San Francisco Code Sprints - March 29-30 and April 4-12, 2012  (Read 6081 times)

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 12, 2012, 07:51:46 pm
OK, expanding on my last comment

 I've just spent about 3 days trying to get receipts up to a customer's requirements - which are - the person's name should be on each receipt, membership join date should show, contribution id should be available, the receipt should know if it's a receipt or invoice & whether it's a renewal or first time membership. It doesn't sound like a lot to ask but there are still 'pathways' (combinations of off-line & online, re-sending receipts, confirming payments)  that don't work.

Spending some time re-factoring receipting could be really useful! I made some comments on the ticket.

http://issues.civicrm.org/jira/browse/CRM-9812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#issue-tabs
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 13, 2012, 04:52:56 pm
Quote
does anyone else think that's too long for a single function?
That gets us into the realm of code cleanup in general, which is always in season. I recently went in to fix the greeting defaults in the BAO so that they would be set when creating contacts via api. Ended up writing a monster patch because I found the same code (for looking up those defaults) repeated SEVEN TIMES throughout the codebase. So I deleted them all and moved it into a function.
What about writing some coding standards and something like the coder module for Civi? Not that I'm volunteering, but I'd be excited to follow standards if they were published.
Try asking your question on the new CiviCRM help site.

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 13, 2012, 05:05:33 pm
I think agreeing some standards at the sprint would be a great idea - they wouldn't be implemented but at least we'd know where we are going & not all be following our own preferences. I have been asked quite a few times about the indentation standard & I don't know if there is one or not (drupal uses 2 spaces).

I do think that code cleanup needs to be put up there along with writing tests & documentation as something that should be looked at every sprint.
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 21, 2012, 04:21:30 pm
Another functionality area high on our list is gift subscriptions

http://forum.civicrm.org/index.php/topic,21367
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

CiviTeacher.com

  • I live on this forum
  • *****
  • Posts: 1282
  • Karma: 118
    • CiviTeacher
  • CiviCRM version: 3.4 - 4.5
  • CMS version: Drupal 6&7, Wordpress
  • MySQL version: 5.1 - 5.5
  • PHP version: 5.2 - 5.4
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 25, 2012, 10:27:28 pm
Agreed on gift subscriptions.

We should compare use cases and requirements from a variety of clients to come up with a solution that could make most of them mostly happy.
Try CiviTeacher: the online video tutorial CiviCRM learning library.

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 25, 2012, 11:26:46 pm
Hi Stoob,

My customer is going to post a blog & a spec in the next day or so - it would be good if you could take a look at that when it comes!

Eileen
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

TwoMice

  • I post frequently
  • ***
  • Posts: 214
  • Karma: 16
    • Emphanos
  • CiviCRM version: Always current stable version
  • CMS version: Drupal 7
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 28, 2012, 10:25:24 am
+1 for coding standards and such.  Indentation, Deepak tells me, is PEAR standard (4 spaces).  But there's much more we could look at; I'd love to be involved in that.  (BTW, I'm most familiar with the Drupal style.)
Please consider contributing to help improve CiviCRM with the Make it Happen! initiative.

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 28, 2012, 01:26:20 pm
Hi,

The latest seems to be we are going for drupal standards (mostly because most are more familiar with them).

I think no one cares (much) either way. Pick whatever colour you want for the bike shed at the sprint and let's repaint the world with it.

X+


-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
March 28, 2012, 01:58:13 pm
Yes agree, I don't mind if it's 2 spaces or 4 - but would like to know what it is
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Michael McAndrew

  • Forum Godess / God
  • I live on this forum
  • *****
  • Posts: 1274
  • Karma: 55
    • Third Sector Design
  • CiviCRM version: various
  • CMS version: Nearly always Drupal
  • MySQL version: 5.5
  • PHP version: 5.3
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
April 01, 2012, 11:08:03 pm
all this talk of coding standards makes me think about user interface standards, which i would personally argue are (even) more important that coding standards.

with each release we have more and more (often very good) innovation in the UI.  The problem is we never go back and uniformly apply this innovation across the UI and so we move further and further away from a standardised look and feel which makes the system much less predictable and therefore much harder and less pleasant for people to use.

Note I'm not talking about bad UI here (though we should fix that as well when we notice it of course) but inconsistent UI. 

i think that coming up with some UI standards is the first step in solving these problems.  I'd love to spend some time at the sprint working on this and I'll bring my copy of 'don't make me think' for inspiration.

Abstracting our UI bits and pieces is probably the second step, especially because that will make 'uniformly applying innovation in the UI' much easier but doing this first step would be a great first step :)

Service providers: Grow your business, build your reputation and support CiviCRM. Become a partner today

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: San Francisco Code Sprints - March 29-30 and April 4-12, 2012
April 02, 2012, 06:39:21 am

At the same time, its also a good idea to keep a running list of things where the same task is done in different ways on different screens.

During the sprint, we can go back and fix a few of those places.

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions
Pages: 1 [2]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion »
  • Sprints »
  • Sprints @ CiviCon 2012 »
  • San Francisco Code Sprints - March 29-30 and April 4-12, 2012

This forum was archived on 2017-11-26.