Author Topic: different problems after upgrading to 4.1.1 and 4.1.2 (Read 2612 times)

CatorgHans · June 06, 2012, 02:18:55 am

@Lobo

It looks like a known problem.
In Job.php:

    //   FIXME: processActivities doesn't return true/false on success/failure

It never returns a value, so it is always perceived as "false" hence

Code: [Select]

return civicrm_api3_create_error( "Process Activities failed");
I tested functionality and it works.

So adding true and false to
CRM_Utils_Mail_EmailProcessor::processActivities()
is the solution.

now that function has

Code: [Select]

         if ( ! $found ) {
             CRM_Core_Error::fatal( ts( 'No mailboxes have been configured for Email to Activity Processing' ) );
         }
     }

what is the CiviCRM way? like this?

Code: [Select]

         if ( ! $found ) {
             CRM_Core_Error::fatal( ts( 'No mailboxes have been configured for Email to Activity Processing' ) );
             return false;
         }
         return true;
     }

Donald Lobo · June 06, 2012, 03:03:02 am

I just checked the code in svn and this seems to be fixed there. We've switched to using exceptions in parts of the codebase

lobo

CiviCRM Community Forums (archive)

News:

Author Topic: different problems after upgrading to 4.1.1 and 4.1.2 (Read 2612 times)

CatorgHans

Re: different problems after upgrading to 4.1.1 and 4.1.2

Donald Lobo

Re: different problems after upgrading to 4.1.1 and 4.1.2