CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion »
  • Report and Search UI Discussion (Moderators: CiviTeacher.com, TwoMice) »
  • Improving the Reports Menu
Pages: 1 [2]

Author Topic: Improving the Reports Menu  (Read 5737 times)

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: Improving the Reports Menu
November 07, 2012, 01:55:29 pm
Ok

Does it mean the civi install that will do an upgrade to 4.3 will get the "old style" menu and the new install will get the new "dave rocks" one?

X+
-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Improving the Reports Menu
November 07, 2012, 02:53:29 pm
As noted on the issue:
"NOTE: For upgrades, the new filtered listing links will be added to the existing Reports menu. Given that users may have made numerous changes to that menu we can't rebuild it. "

I really don't think we can "blow away" the existing Reports menus during upgrade, so adding the additional menu items (below) seemed like a decent compromise. If you have other ideas - let's chat.
Protect your investment in CiviCRM by  becoming a Member!

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: Improving the Reports Menu
November 07, 2012, 03:18:33 pm
Hi,

Seems a good enough solution, was more to keep in mind that different users will have different menus.

Would it be simplish to have an option "reset the report menu to the default" as a link/drush command/sql file/api cli/whatever? ie. we don't reset the report menu by default, but let the user decides that the new menu is worthwhile loosing the few customisation she might have done?

A bit like debian does in an update, it offers the option to keep the existing version or replace by the new one (it's smart enough to know if the local existing version has been modified and show a diff, probably way too complex to put in place for a not so big benefit on our case).

X+
-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Improving the Reports Menu
November 08, 2012, 01:52:24 pm
The upgrade framework doesn't have support for taking user input up front and branching on processing. An alternative approach would be to create a separate task that can be invoked via clickable URL or via command line and invite folks to click that in the post upgrade message.

If you're up for implementing this, you can check what was done for the 4.2.5 price set upgrade cleanup 'invite'. If you grep for 'civicrm/upgrade/cleanup425' in 4.2 you'll see the implementation pieces. You'll definitely need to do some thorough testing to make sure the code only replaces items in the Reports menu and doesn't break anything else :-)
Protect your investment in CiviCRM by  becoming a Member!

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: Improving the Reports Menu
November 09, 2012, 03:06:24 am
Hi,

I'm going to start with an extension/script "replace by new report menu". Trying to find the Upgrade script that did the upgrade for the Admin menu, but greping around didn't help.

Does someone remember where is it?
-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Improving the Reports Menu
November 09, 2012, 03:07:27 pm
Sounds like a good idea.
Admin menu rebuild is in CRM/Upgrade/Incremental/sql/4.1.alpha1.mysql.tpl
Protect your investment in CiviCRM by  becoming a Member!
Pages: 1 [2]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion »
  • Report and Search UI Discussion (Moderators: CiviTeacher.com, TwoMice) »
  • Improving the Reports Menu

This forum was archived on 2017-11-26.