CiviCRM Community Forums (archive)

I did in fact just have the BAO evaluate the id or contact_id param with is_array() and make the clause "IN" accordingly. In the PHP api call, a Contact Get will now simply take an array in addition to an integer. I don't think I'm following how you're suggesting using the + operator.

I'm happy to make the change, but I don't see exactly where that is being handled. I also don't know how that reconciles with Eileen's comments, since I wasn't quite clear what she was getting at.

Ok. Based on that, I'll need to rework what I was doing, as the patch in CRM-12051 for CRM_Contact_BAO_Query only checks to see if the id param is passed, and checks to see if it is an array. If is_array is true, then it assumes that the array is an array of integers and implodes to a list, and creates the IN statement accordingly. This is actually being done in CRM_Contact_BAO_Query::whereClause(), but it would seem an additional method would be in order.

If we're going to the trouble to make all of the operators available, it would make sense to actually key the array, so that you could potentially pass multiple conditions. i.e. --

Instead of

civicrm_api('contact', 'get', array('version' => 3, 'id' => array('IN', array(1,2,3,4,)));
-> creates condition 'id IN (1,2,3,4)'

Use

civicrm_api('contact', 'get', array('version' => 3, 'id' => array('BETWEEN' => array(1,4,), '!=' => 3)));
-> creates conditions 'id BETWEEN 1 AND 4 AND  id != 3'


That still didn't answer my other question about where the input from an AJAX request is interpreted, since the input will have be converted into the array format we're discussing.

If we're going to the trouble to make all of the operators available, it would make sense to actually key the array, so that you could potentially pass multiple conditions. i.e. --

I think what you are suggesting would be supported by the DAO based functions already based on this.

It seems it would use 'AND' and 'OR' would still be unavailable - but if we start looking @ a syntax for 'OR' we'd need to not limit it to 1 field so consisentency on the existing syntax probably matters more.

I've put a mockup of how we might restructure the existing function onto the DAO so it is more generic

https://github.com/eileenmcnaughton/civicrm-core/commit/56d5716e7f9cc1e5f81e6f8f63b3982bff640962

I think this is not valid json. It should be

Code: [Select]

json={"id":{"in":[1,2,3,4]}}
right?

yes, thanks.

But even with the correct syntax an error message "no such field" is returned. Is there something wrong with the parameter or is it not possible at the moment, to request contacts (or other entities) by multiple ids?

json is possible, but the underlying api doesn't support multiple ids query yet.
As soon as we receive your patch+test, you'd get it working from ajax, smarty, rest and php

X+

Cool, if either of you is around in london on oct 3-4, you should come and present the result at civicon.

X+