CiviCRM Community Forums (archive)

I like how it delegates uninstallPermissions() and upgradePermissions() to each CMS class, and the D7 implementations seem good.

Rewriting long permission-names in D7 (e.g. the "$module|" . md5($key)) also seems clever. (Aside: Does that work intuitively with CRM_Core_Permission::check?)

There is some difficulty in the getModulePermissions($module) and commonModuleImplements():
 * Based on the D7 impl of getModulePermissions, I get the impression that this should work with both Civi ext-modules and CMS modules.
 * Well, kind-of: removePermissions() will be called for Civi ext-modules but not Drupal modules.
 * The technique cannot be adapted to Joomla plugins. The problem is that the central registry for Joomla plugins (JDispatcher/JPluginHelper) doesn't expose that information. One could create a "work-a-like" that instantiates plugins much like JDispatcher/JPluginHelper, but it'll deviate slightly from standards (e.g. any $this->foo variables will misbehave).
 * If a developer edits a module and completely removes the hook (but doesn't uninstall the module), then the upgradePermissions() tool won't run.

Fortunately, I think we can sidestep most of this. The CMS's already provide their own ways to declare permissions. If you're writing a Drupal module or Joomla plugin, then you don't need hook_civicrm_permissions. You can use the CMS's convention. We only need hook_civicrm_permissions for Civi ext-modules.

You might change the implementation of CRM_Core_Config::cleanupPermisisons to run upgradePermissions() for *every* native extension (and only native extensions), regardless of whether they currently implement the hook. You might get a list of these by calling one of:

CRM_Extension_System::singleton()->getMapper()->getModules()
CRM_Extension_System::singleton()->getMapper()->getActiveModuleFiles()

Thanks for the help totten, this is great input.

I've implemented your suggestion to clean up permissions for all and only CiviCRM native extensions on menu rebuild. Great point.

I've also refactored the moduleImplements() and getModulePermissions() stuff so that it doesn't affect Joomla. Glad you spotted that.

I suppose I'll go ahead and commit. Feel free to ping me if it needs more attention.

Thanks!

- Allen