CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Sneak Peak: PR Testing
Pages: 1 [2]

Author Topic: Sneak Peak: PR Testing  (Read 2241 times)

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: Sneak Peak: PR Testing
July 29, 2014, 03:37:55 am
What's the current status? When I submit e.g. https://github.com/civicrm/civicrm-core/pull/3745 (which makes a change to the api), what tests are being run? Looking at the console output it looks like the upgrade suite is running and a subset of CiviTest (not sure how that's being determined) but not the api test suite?
Try asking your question on the new CiviCRM help site.

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Sneak Peak: PR Testing
July 29, 2014, 03:59:28 am
It's either because you are above questioning or because that api is so awful it runs away screaming like I do every time I see it.

ps  last time I added that function to the BAO (where I think it belongs) but it got removed because there are forms that run it too so it got run twice :-( I never found out when it happened or I would have taken it out of the forms & put it back in the BAO
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: Sneak Peak: PR Testing
July 29, 2014, 04:25:33 am
Eileen I agree that's the "right" fix but this late in the release cycle this'll have to do. At least now it works.
Try asking your question on the new CiviCRM help site.

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Sneak Peak: PR Testing
July 29, 2014, 04:27:15 am
yes - the right fix was pulled out of 4.4 during alpha I think (or maybe even before it went alpha)
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

totten

  • Administrator
  • Ask me questions
  • *****
  • Posts: 695
  • Karma: 64
Re: Sneak Peak: PR Testing
July 29, 2014, 06:01:29 am
Quote from: Coleman Watts on July 29, 2014, 03:37:55 am
What's the current status? When I submit e.g. https://github.com/civicrm/civicrm-core/pull/3745 (which makes a change to the api), what tests are being run? Looking at the console output it looks like the upgrade suite is running and a subset of CiviTest (not sure how that's being determined) but not the api test suite?

Correct, it was set to only try a handful of tests. I've broadened it to include api_v3_AllTests for now (but not much of CRM_AllTests and none of WebTest_AllTests). That should apply to any future test runs. In this configuration, I'd guesstimate 30-40min turn-around between submitting/updating a PR and getting the results, but we'll see when someone submits/updates a PR...

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Sneak Peak: PR Testing
July 29, 2014, 06:28:21 am
submitted - https://github.com/civicrm/civicrm-core/pull/3746 - now we can see :-)
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Sneak Peak: PR Testing
July 29, 2014, 06:30:41 pm
so that PR failed on pre-exising test failures from what I can see.
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute
Pages: 1 [2]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Sneak Peak: PR Testing

This forum was archived on 2017-11-26.