CiviCRM Community Forums (archive)

The javascript popup that handles tokens was not functional on our 3.0.0 Stable install, so I fixed a few problems. The two javascript variables at the top of /templates/CRM/common/Filter.tpl had/have problems. First is that (evidently) the "document" object isn't happy being assigned to a global variable, and all global variables must be instantiated using "var" prior to the variable name.

Here's the diff on that file for the fixes I made to get it working on our server.

Let me know if I should go ahead and file this with the issue tracker.


--- Desktop/civicrm/templates/CRM/common/Filter.tpl     2009-09-25 06:17:59.000000000 -0700
+++ NetBeansProjects/GW/sites/all/modules/civicrm/templates/CRM/common/Filter.tpl       2009-10-03 12:53:55.000000000 -0700
@@ -1,10 +1,10 @@
 {literal}
-d = document;
-stregexp = new RegExp;
+var stregexp = new RegExp;
 
 function initFilter( id ) {
     //build the array
     filterArray = new Array();
+
     {/literal}
     {foreach from=$tokens item=tokenName key=tokenKey}
     filterArray["{$tokenKey}"] = "{$tokenName}";
@@ -14,13 +14,13 @@ function initFilter( id ) {
     remvdArray = new Array();
 
     //get select object
-    selObj = d.getElementById("token"+ id);
+    selObj = document.getElementById("token"+ id);
 
     //rebuild the list
     buildOptions(filterArray);
 
     //clear the input box
-    d.getElementById("filter"+id).value = "";
+    document.getElementById("filter"+id).value = "";
 
     //clear the last typed value
     lastVal = "";
@@ -109,9 +109,9 @@ function buildRemvd( ) {
 
 function getMatches(id) {
     if ( selObj.options.length == 1 ) {
-        d.getElementById("match"+id).innerHTML = "{/literal}{ts}1 match{/ts}{literal}";
+        document.getElementById("match"+id).innerHTML = "{/literal}{ts}1 match{/ts}{literal}";
     } else {
-        d.getElementById("match"+id).innerHTML = selObj.options.length +" {/literal}{ts}matches{/ts}{literal}";
+        document.getElementById("match"+id).innerHTML = selObj.options.length +" {/literal}{ts}matches{/ts}{literal}";
     }
 }
 {/literal}