CiviCRM Community Forums (archive)

Hi guys,
this is my first forum post, although been using civicrm for a UK government project for about 6 months now. Great piece of software so thanks a lot for all your hard work.

I have discovered what I think might be a bug in the latest version (3.0.1) with drupal - although please correct me if I am not understanding how it works correctly.

After upgrading my dev server to version 3 and updating the custom templates etc. we are using, I noticed the custom css url is no longer working. We have some custom css we use in addition to the main civicrm.css file, specific to the crm pages on our site. Previously (in v. 2.2.6), we could set a custom css url in 'Administer->Global Settings->Resource urls->Custom CiviCRM CSS URL, and this would replace the main civicrm.css file. In v3.0.1 entering a value in this field appears to remove the main civicrm.css file from the HTML source, but not replace it with the new custom url entered in the box.

I did a bit of digging and it seems to me the problem is in the civicrm drupal module (civicrm/drupal/civicrm.module), in the 'civicrm_html_head()' function.

    if ( isset( $config->customCSSURL ) && ! empty( $config->customCSSURL ) ) {
        $head  = "<style type=\"text/css\">@import url({$config->customCSSURL});</style>\n";
    } else {
        drupal_add_css(drupal_get_path('module', 'civicrm') . '/../css/civicrm.css');
    }

Here, the first part of the if statement adds the custom URL to the page head if one is set. This seems to work ok as I did some debug output checks on this value. The problem comes later in the function here:

    if ( $includeCommon ) {
        $template =& CRM_Core_Smarty::singleton( );
        $head = $template->fetch( 'CRM/common/jquery.tpl' );
    }

where the head value is again reset to the value of the jquery template, thus wiping out the earlier HTML which adds the css file. My fix was simple, to change the '$head =' to '$head .=':

    if ( $includeCommon ) {
        $template =& CRM_Core_Smarty::singleton( );
        $head .= $template->fetch( 'CRM/common/jquery.tpl' );
    }

Is this intentional or a bug? Any chance it could get into the next patch.

Are members of the public allowed to sign up to the JIRA issue queue system and post issues in there or is that just for the core team? If it's allowed I'll happily post an issue in there.

Cheers

Graham

hi Graham,

Is this intentional or a bug? Any chance it could get into the next patch.

It's a typo bug.

Issue filed is here : http://issues.civicrm.org/jira/browse/CRM-5242

thanks for catching

kiran

this is my first forum post, although been using civicrm for a UK government project for about 6 months now. Great piece of software so thanks a lot for all your hard work.

Hey graham:

can you describe what you have been using CiviCRM for and how its working out. Would be great if you can follow that up with a case study here: http://wiki.civicrm.org/confluence/display/CRMDOC/Case+Studies Great way to give back to the project and serves as excellent marketing material for the project

thanx

lobo