Author Topic: remove dash (-) from all variables (Read 2481 times)

lcdweb · October 27, 2009, 07:29:10 am

I'd like to propose that all variable constructions currently using dashes be replaced by underscores. The constructions are most prevalent with addresses, phones, emails, etc. -- such as "street_address-5" where the "-5" indicates the address type.

The use of dashes is problematic for both smarty vars and javascript, requiring workarounds that clutter code.

Kurund Jalmi · October 29, 2009, 04:18:57 am

Quote

"street_address-5"

Here "-" stands for location type. So when form etc is submitted its easy to split field name and location type.

Kurund

lcdweb · October 29, 2009, 04:28:27 am

Right...
But when passed to the smarty template it has to be re-assigned as smarty won't play with variables containing dashes. It seems to me that variable issue should be fixed before it's passed to smarty so we don't have to deal with it in the template.

Donald Lobo · October 29, 2009, 10:18:26 am

yes, this is a fairly substantial project and not sure whether it is really "worth" it.

We'll have to change the code/protocol in quite a few php/tpl files

lobo

CiviCRM Community Forums (archive)

News:

Author Topic: remove dash (-) from all variables (Read 2481 times)

lcdweb

remove dash (-) from all variables

Kurund Jalmi

Re: remove dash (-) from all variables

lcdweb

Re: remove dash (-) from all variables

Donald Lobo

Re: remove dash (-) from all variables