Author Topic: UpdateGreeting.php has no effect (Read 843 times)

kmarkley · February 28, 2010, 08:18:02 pm

Subject kind of says it all. Except that the full result is: "Greeting is updated for contact(s). (Done)".

I've been mucking about in the code on my test server, and I am pretty sure this is a simple typo/bug. But because I don't really understand the code ("mucking about" being my phrase for trying to learn stuff), I'd like it someone confirmed this before I go posting a patch in the issues queue.

I think the SQL statement on line 131:

SELECT DISTINCT id
FROM civicrm_contact
WHERE contact_type = %1
AND {$idFldName} IS NOT NULL

should be:

SELECT DISTINCT id
FROM civicrm_contact
WHERE contact_type = %1
AND {$idFldName} IS NULL

Basically it looks like the script was only trying to update greetings that didn't need it.

Am I correct here?

Kurund Jalmi · March 01, 2010, 03:03:56 am

Quote

SELECT DISTINCT id
FROM civicrm_contact
WHERE contact_type = %1
AND {$idFldName} IS NOT NULL

This is correct SQL. This will select contacts whose greeting type is already set. This SQL is called if url does not have force=1, which means update contacts whose greeting type is set. If you pass force = 1 then it will update all contacts in your db.

HTh
Kurund

CiviCRM Community Forums (archive)

News:

Author Topic: UpdateGreeting.php has no effect (Read 843 times)

kmarkley

UpdateGreeting.php has no effect

Kurund Jalmi

Re: UpdateGreeting.php has no effect