CiviCRM Community Forums (archive)

Here's a patch that works for this

Should it go in Core?

The ideal action link for a pending registration is one that allows the registration to be completed (or deleted).

Renewing a pending registration seems incorrect as there is not a completed registration to renew and many (most) pending registrations are previous incomplete efforts (often because of entering an incorrect credit card or something).


Index: civicrm/v3.0.2/custom_templates/Member/Page/UserDashboard.tpl
===================================================================
--- civicrm/v3.0.2/custom_templates/Member/Page/UserDashboard.tpl (revision 56)
+++ civicrm/v3.0.2/custom_templates/Member/Page/UserDashboard.tpl (working copy)
@@ -1,3 +1,4 @@
+{* Fuzion edited file so that pending registrations would not have a renew link *}
 <div class="view-content">
 {if $activeMembers}
 <div id="memberships">
@@ -17,7 +18,14 @@
          <td>{$activeMember.start_date|crmDate}</td>
          <td>{$activeMember.end_date|crmDate}</td>
          <td>{$activeMember.status}</td>
-         <td>{if $activeMember.renewPageId}<a href="{crmURL p='civicrm/contribute/transact' q="id=`$activeMember.renewPageId`&mid=`$activeMember.id`&reset=1"}">[ {ts}Renew Now{/ts} ]</a>{/if}</td>
+ <td>
+ {*Fuzion edit starts*}
+ {if $activeMember.status neq 'Pending'}
+ {if $activeMember.renewPageId}<a href="{crmURL p='civicrm/contribute/transact' q="id=`$activeMember.renewPageId`&mid=`$activeMember.id`&reset=1"}">[ {ts}Renew Now{/ts} ]</a>{/if}
+ {/if}
+ {*Fuzion edit ends*}
+
+ </td>
         </tr>
         {/foreach}
         </table>
@@ -47,8 +55,11 @@
          <td>{$inActiveMember.start_date|crmDate}</td>
          <td>{$inActiveMember.end_date|crmDate}</td>
          <td>{$inActiveMember.status}</td>
-         <td>{if $inActiveMember.renewPageId}<a href="{crmURL p='civicrm/contribute/transact' q="id=`$inActiveMember.renewPageId`&mid=`$inActiveMember.id`&reset=1"}">[ {ts}Renew Now{/ts} ]</a>{/if}</td>
-
+ {*Fuzion edit starts*}
+ {if $inActiveMember.status neq 'Pending'}
+ <td>{if $inActiveMember.renewPageId}<a href="{crmURL p='civicrm/contribute/transact' q="id=`$inActiveMember.renewPageId`&mid=`$inActiveMember.id`&reset=1"}">[ {ts}Renew Now{/ts} ]</a>{/if}</td>
+ {/if}
+ {*Fuzion edit ends*}
         </tr>
         {/foreach}
         </table>


Hi,

Does anyone have an opinion on this? We think it would better to put the patch in core but that might just be our take on renewing memberships.

ie. if you renew a pending & make it current the entire membership duration would appear to be from the start of the 'pending' to the new expiry date? That seems wrong