CiviCRM Community Forums (archive)

Pending refers to awaiting payment.

There are a few people I know of trying to work around the fact there is no 'awaiting approval' status - probably a field for it would be better because both unpaid and paid memberships can be awaiting approval.

We might be able to get a client to pitch in a few dollars towards a patch on this if other people can? It would need to tie in with the drupal members sync module to be useful though

Lobo, do you have an estimate on what might be involved to do this. Without diving into the code  I'm not sure but I'm guessing that what's required

1) add an extra (boolean) field to civicrm_membership_type for 'approval_required'
2) add an extra (boolean) field to civicrm_membership for 'approved'
3) modify the code that defines whether a membership is 'current' to say that if approval_required applies to the membership type and !approved then the membership is not current - what does the definition of current affect - other than the drupal role sync?
4) add a approval required field to the membership type configuration form
5) add a 'approved' checkbox to the 'edit membership form
6) add 'approved' checkbox to advanced search
7) extra - add a batch action of 'approve' to the find membership results

Any comments? I think #3 in particular is where I am uncertain

One extra wee bit we have picked up elsewhere is the rule in regards to whether Memberships have a 'renew' option on the Membership dashboard in case tht is something that needs picking up here too, ie 'awaiting for approval' should not display 'renew'.

I'm not 100% sure what this refers to, but in my particular use case a membership would only need to be reviewed/approved once, i.e. at the point where the new membership application is received. It would very likely not need to be reviewed at the point of renewal (although I could see other use cases where that would be happening).

Eileen:

in think your plan sounds good, however i suspect i would check out how civievent handles approvals (via event status) and i suspect generalizing the code to have another status which is pending approval might be a bit more inline with the rest of the codebase

lobo

Just a note to say after some thought I'm pretty sure the determination of whether a membership requires approval or not should be assigned to the membership type (not the contribution page). We are already having a bunch of problems with contribution pages not being assigned for back-office registrations (which means that renewal links don't work and the receipts are 'wrong' because they don't include the profile fields (e.g. name, address etc) that were on the on-line registrations.