CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Discussion (deprecated) »
  • Alpha and Beta Release Testing »
  • 3.2 Release Testing »
  • CRM-5724 - I'm confused by implementation
Pages: [1]

Author Topic: CRM-5724 - I'm confused by implementation  (Read 2500 times)

ken

  • I live on this forum
  • *****
  • Posts: 916
  • Karma: 53
    • City Bible Forum
  • CiviCRM version: 4.6.3
  • CMS version: Drupal 7.36
  • MySQL version: 5.5.41
  • PHP version: 5.3.10
CRM-5724 - I'm confused by implementation
May 16, 2010, 02:42:10 am
I am confused by the implementation of CRM-5724 on the sandbox (r27666). CRM-5724 refers to a forum post I made, but the description on the sandbox indicates a different function has been implemented.

The issue description of CRM-5724 (by referring to my post) suggests that the value of the new "participant count" field means something like "this number is the count of participants that this price option contributes to the total count of participants in this event". So if booking a table of 8 participants costs $350, the price will be $350 and the participant count will be 8. If I book 2 tables, I will be charged $700 and the number of participants will increase by 16.

However, when I edit a price field on the sandbox, the field is called "Number available" and the remark is "If there is a limit on how many participants can select this event item, enter that number here."

It seems that this field is really a "participant count", and not a "number available" because when I enter the erroneous value "-2" the error is "Participant Count should be a positive number".

Could the function of CRM-5724 be clarified? It's not clear to me what has been implemented.

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: CRM-5724 - I'm confused by implementation
May 16, 2010, 06:37:41 am

CRM-5724 is basically an implementation of what kmarkley paid for :)

Its a max count on the number of slots for each price field. So basically if a participant exceeds that count, he'll get a denied message

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

ken

  • I live on this forum
  • *****
  • Posts: 916
  • Karma: 53
    • City Bible Forum
  • CiviCRM version: 4.6.3
  • CMS version: Drupal 7.36
  • MySQL version: 5.5.41
  • PHP version: 5.3.10
Re: CRM-5724 - I'm confused by implementation
May 16, 2010, 05:46:16 pm
Lobo,

I can't argue with $'s! :) But it does seem that there is some confusion in the choice of names in the implementation.

A quick scan of the changed code reveals the schema has two new fields: "participants" in the price field table, described as "Participant count for field."; and "participant_count" in the line item field, described as "Number of Participants Per field."

Your description suggests that what is being counted is not 'participants' but the usage of some resource associated with the price field.

Can I suggest that (for the sake of future maintainers) the fields are renamed something like "event limit" for the price field and "event limit usage" for the line item? I don't think the current names and descriptions say what is meant.

Ken

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: CRM-5724 - I'm confused by implementation
May 17, 2010, 01:59:57 pm
Hi Ken - I think we've had some confusion internally about this since there were two different features affecting price set fields. I'll chat w/ Yashodha tomorrow and try and clear things up both in the UI and the issue and the doc. Will post back here.
Protect your investment in CiviCRM by  becoming a Member!

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: CRM-5724 - I'm confused by implementation
May 19, 2010, 04:24:01 pm
Ok - cleared up what was done and where. The functionality in 3.2 is to assign a participant count at the price set field level (as stated by Ken W). I've relabeled the field to "Participant Count" and put the following text below it:

"Enter a value here if you want to increment the number of registered participants per unit against the maximum number of participants allowed for this event. For example, if this price field is for a table at a fundraiser which seats eight people, you would set Participant Count to 8."

Suggestions for clarifying the "help" are welcome :-)
Protect your investment in CiviCRM by  becoming a Member!

ken

  • I live on this forum
  • *****
  • Posts: 916
  • Karma: 53
    • City Bible Forum
  • CiviCRM version: 4.6.3
  • CMS version: Drupal 7.36
  • MySQL version: 5.5.41
  • PHP version: 5.3.10
Re: CRM-5724 - I'm confused by implementation
May 21, 2010, 04:21:13 pm
Beautiful!

This will be a significant improvement,

Thanks,

Ken

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Discussion (deprecated) »
  • Alpha and Beta Release Testing »
  • 3.2 Release Testing »
  • CRM-5724 - I'm confused by implementation

This forum was archived on 2017-11-26.