CiviCRM Community Forums (archive)

Hi,

I just sent out a mailing that went to 866 recipients, but each one got 2 emails.  On the report screen for this mailing in the Delivery Summary section, the Intended Recipients is 1728, or twice the 866.  In the Recipients section it says Included: Members of "Member Mailing List", and when I click on that link it has the 866 number. 

When I go to Delivery Summary: Succesful Deliveries link, it shows every member there twice, and shows that it went through the list one time and then when done wen through it a second time.

I am concerned that this will happen again when I sent another email to the same group. 

Any suggestions on how to debug what happened to insure that it won't happen again?

when a "process" (whether cron or via browser) is sending a mailing, it basically acquires a DB lock on the job in the database

thus in the below scenario, what should have happened is the first cron job should skip the second mailing, since it would not be able to get a lock on it

However (i'm thinking of scenarios here), if the second cron job finished and relinquished the lock before the first cron job's request timed out (we use a 1 second timeout wait), the first cron job could potentially resend the mailing. the chances of this happening are fairly low (but still significantly greater than 0, IMO)

What needs to happen, is once we get the lock, we refetch the job record from the DB and test and make sure it is still scheduled or running. We then operate on it with the new values. This will close the above potentially small but greater than zero hole

thoughts?

lobo

you are right and basically your logic makes the probability of it happening even more

if you can file an issue, i can work on the patch. if you can think of how to test this scenario, that would be great, so we know the patch works

lobo

you might want to try this patch and see if u can simulate the previous scenario and test it out.

http://paste2.org/p/841205

Note that locking at the job level allows organizations to have multiple jobs run in parallel thus increasing speed/thruput etc. A large part of the time spent is on the network connection to the SMTP server and hence this is quite useful, IMO

lobo