CiviCRM Community Forums (archive)

I found that if the user presses submit on a donation page and the credit card number is blank I would get an warning on the top of the page:

Warning: str_repeat() [function.str-repeat]: Second argument has to be greater than or equal to 0. in $BASE/administrator/components/com_civicrm/civicrm/CRM/Utils/System.php on line 597

I've modified System.php as follows:

Change from:
    static function mungeCreditCard( $number, $keep = 4 ) {
        $replace = str_repeat( '*' , strlen( $number ) - $keep );
        return substr_replace( $number, $replace, 0, -$keep );
    }

Change to:

    static function mungeCreditCard( $number, $keep = 4 ) {
        $leng = strlen( $number );
        if ($leng < $keep ) {
           $leng = $keep;
        }
        $replace = str_repeat( '*' , $leng - $keep );
        return substr_replace( $number, $replace, 0, -$keep );
    }

I'm assuming the payment page will catch the blank credit card number (haven't gotten that part complete yet).

Warning - I'm new at this! 

I couldn't get the same error on the demo site.  I just reverted the code in System.php back to see if I still get the same error and it still occurs.

Some additonal info:

I have selected Pay Pal Pro with a paypal sandbox account.

As long as I fillout the other required info (email address, firstname, lastname) and leave the credit card blank I get the error.

NOTE:  I'm using php version 5.2.3.  According to

http://wiki.civicrm.org/confluence/display/CRMDOC/PayPal+Website+Payments+Pro+and+Express+Configuration

5.2.3 is NOT compatible with PayPal Pro.  (I couldn't find ANY verification of this on pay pal's site).  Could it be that PayPal Pro is fine with 5.2.3, however they System.php current use of str_repeat is the problem?  Did str_repeat change from php 5.2.0 to 5.2.3?