CiviCRM Community Forums (archive)

Currently the links created by this hook are displayed well enough to work properly, which is great, but I'd like to request that we have them displayed in similar fashion to the other links around them.  This is not possible now because of the way they're output to the browser.

Whereas other links across the top of the Contact Summary are each presented in an <li> element of <ul id="actions">, these links are actually inserted as simple <a> links all within the same <li> as the activities drop-down list.

To change this, I would like to move the processing for {$hookLinks} out of templates/CRM/Activity/Form/ActivityLinks.tpl and into /templates/CRM/Contact/Page/View/Summary.tpl, where they can be processed as individual <li> elements each containing a single <a> element.

(BTW, I have also submitted a patch providing support for 'id' attributes on these links, but this seems like it's different enough to warrant a little more discussion.)

Any reaction from the CiviCRM core team?

Thanks,
Allen

HI Kurund,

Oh, sure.  Actually, I'm only suggesting changing the template itself, not inserting HTML into the structure of the hook's return value.  The hook's return value data structure can remain unchanged.

Here's some sample template output to illustrate.  Right now the hook's return value is passed to the template as $hookLinks, which the template processes by inserting them into the same <li> as the actions <select> element, like so (this code is created by templates/CRM/Activity/Form/ActivityLinks.tpl) :

<ul id="actions">
    <li> <!-- EDIT link is here -->  </li>
   
    <li> <!-- DELETE link is here --> </li>
   
    <li>
        <select class="form-select" id="other_activity" name="other_activity" onchange="...">  <!-- options --> </select>
        <!-- here's where the hook links are inserted -->
        <a href="hook/path/foo">Foo</a>
        <a href="hook/path/bar">Bar</a>
        <a href="hook/path/baz">Baz</a>
    </li>
   
    <li> <span class="label">Go to:</span> </li>
    <li> <!-- DASHBOARD link is here --> </li>

I'm suggesting that we use the template to render those hook links as <li><a>x</a></li>, like so:

<ul id="actions">
    <li> <!-- EDIT link is here --> </li>
   
    <li> <!-- DELETE link is here --> </li>
   
    <li>
        <select class="form-select" id="other_activity" name="other_activity" onchange="..."> <!-- options --> </select>
    </li>
   
    <!-- here's where the hook links are inserted -->
    <li> <a href="hook/path/foo">Foo</a> </li>
    <li> <a href="hook/path/bar">Bar</a> </li>
    <li> <a href="hook/path/baz">Baz</a> </li>   
   
    <li> <span class="label">Go to:</span> </li>
    <li> <!-- DASHBOARD link is here --> </li>
</ul>
To make this change, we would need to take the {$hookLinks} processing out of templates/CRM/Activity/Form/ActivityLinks.tpl and put it in templates/CRM/Contact/Page/View/Summary.tpl

I'm attaching a small patch to show more clearly what I'm suggesting.

What do you think?

- A.

Looks like 3.2 will change the context of this discussion.  Will have to play with that and bring this up again if necessary.

Thanks.

- A.