CiviCRM Community Forums (archive)

based on your past forum posts, i'd highly recommend u hire someone from:

http://civicrm.org/professional/

to help you with installing and adapting civicrm for your org

lobo

I'm getting the same error and I suspect Lobo didn't quite understand the problem (because this is a civicrm bug, not a custom integration issue).

Here's the scenario:
1. create a custom data file field in civicrm (e.g. your CV/resume)
2. add the field to a profile (e.g. member information) and make it required.
3. add the profile to a contribute/membership form.
4. try to use the form - despite adding files to the fields, when you submit the form, civicrm will return errors that the file fields are required.

I've made a demo here:
https://drupal.demo.civicrm.org/civicrm/contribute/transact?reset=1&action=preview&id=5
add a file and click confirm.  civi will return an error that the file field is required.

Dave, thanks for the insight about for membership vs. individual/contact.  I'll give that a try and it should be an acceptable workaround for my current project.  I wish i had a larger budget and more time to correct the issue rather than working around it... maybe some other time.

Just an update from putting some devel dpm()'s in /CRM/Core/QuickForm/Action/Upload.php: it seems that the contribute pages instantiate the CRM_Core_QuickForm_Action_Upload class, but never actually call the upload() function.

So, essentially it's a dead field - shows up on the front, doesn't do anything on the back.

Been working on this all day... here's what i've got:

CRM/Contribute/Form/Contribution/Main.php, around line 858:
Validation is run against fields, but not files, so required file fields would always fail.
changing this:
            if ( $fld['is_required'] &&
                 CRM_Utils_System::isNull( CRM_Utils_Array::value( $name, $fields ) ) ) {
                $errors[$name] = ts( '%1 is a required field.', array( 1 => $fld['title'] ) );
            } 

to this:
            if ( $fld['is_required'] &&
                 CRM_Utils_System::isNull( CRM_Utils_Array::value( $name, $files ) ) &&
                 CRM_Utils_System::isNull( CRM_Utils_Array::value( $name, $fields ) ) ) {
                $errors[$name] = ts( '%1 is a required field.', array( 1 => $fld['title'] ) );
            } 

seems to help. 

The file then appears to be successfully uploaded, but it never gets an entry into the civicrm_file table.  That causes an error when civi later tries to update the civicrm_value_custom_field_# table, because it receives null instead of the integer foreign key to civicrm_file. 

In CRM/Core/QuickForm/Action/Upload.php realPerform() about line 150, $page->mainProcess() doesn't do anything for contribute forms.  However, when editing a contact's membership, the file field works and that call passes off to something that then adds the correct entry in the civicrm_file table.

Hopefully all that makes sense.  In general, I'm just trying to compare membership (which works) to contribute (which doesn't)... I hope i'm going down the right track.

Lobo,

Thanks... I had gone back to 3.1.5, but a combination of upgrading to 3.2.3 again and modifying CRM/Contribute/Form/Contribution/Main.php to check $files (instead of just $fields) seems to have done the trick.

So, for anyone who finds this thread later, here's the summary:

1. Upgrade to 3.2.3 (or later... might be fixed in earlier versions of 3.2 as well)
2. Modify your CRM/Contribute/Form/Contribution/Main.php file as described above.