CiviCRM Community Forums (archive)

We have the need to assign a custom member ID for anyone who gets a membership on our site.  With a few exceptions that will be handled manually, the member ID is the current maximum member ID +1.  I have a custom field created for this already (and populated with our current membership), but I wanted to get a sanity check on the hook I have written for updating this value for new members before I deploy it since I haven't written a CiviCRM hook before...

The algorithm I think I am using is (this should only be run on a new membership):

• Check for an existing ID for the contact, if one exists do nothing
• If one doesn't exist, get the highest ID from the custom data table and add 1
• Assign the new ID to the contact

/*
 * Post-process membership forms to make sure we have a memberID
 */
function CiviLOPSA_civicrm_postProcess( $formName, &$form ) {
  /* Don't do anything of not a new membership */
  if ($formName == 'CRM_Member_Form') {
    $userID   = $form->getVar( '_id' );

    /* Query the memberID custom field for the max and add 1 for new ID */
    $query = "
SELECT member_id_10
FROM civicrm_value_member_data_4
WHERE entity_id = %1
";
    $params = array( 1  => array( $userID, 'Integer' ));
    $dao = CRM_Core_DAO::executeQuery( $query, $params );

    /* If one exists we're done, otherwise generate a new one */
    if (! $dao->fetch()) {
       $query = "
SELECT max(member_id_10)
FROM civicrm_value_member_data_4
";
      $dao = CRM_Core_DAO::executeQuery( $query, CRM_Core_DAO::$_nullArray );
      if ( $dao->fetch() ) {
        $memberID = $dao->member_id;
        $memberID++;
        $params = array('entity_id' => $userID,
                        $custom_fields['member_id'] => $memberID);
        CRM_Core_BAO_CustomValueTable::setValues($params);
      }
    }
  }
}


any specific reason why u r not using the 'id' column from the civicrm_membership table?

it basically has exactly the same rules (its an auto-increment field)

lobo

The above only applies to new users, we have existing users with numbers all over the map.  We have a couple of member classes that allow the user to select a member ID, and we still need to support that.  An auto-increment field will give us problems down the road when we need to override the value.