Author Topic: a couple trashed record issues (Read 649 times)

lcdweb · August 24, 2010, 06:24:51 am

1) the contributions mini-report that displays above search results INCLUDES contribs attached to trashed records, though the list of returned records does not. so the mini report may state 7 records, while only 6 are returned

2) if a trashed record is connected in some way with an activity, the connection is retained but nothing is displayed in the activity field. for example:

John Doe adds an activity to Jim Smith (added by = John Doe)
John Doe is trashed
the activity still exists with Jim Smith, but the added by field displays empty
if we restore John Doe, the name is restored in the activity record

For situations where a trashed record has connections with some other contact via activities, relationships, etc. we obviously don't want to lose that related record (as it impacts others). but the empty field is confusing. i think we want John Doe listed but with the strike-out style so there's a visual cue to his contact status.

xavier · August 24, 2010, 06:27:04 am

What happens when you hard delete John Doe ? Does it delete the activity or display the source field empty ?

X+

Donald Lobo · August 24, 2010, 07:54:25 am

1. is a bug. would be great if you can check the code and file an issue along with a patch. Whats the mini-report?

2. activities are a bit wierd since they connect so many contacts (source, targets and assignees).

IMO, the trashed behavior should be exactly the same as when a contact is deleted. The only difference is people with "admin" access can go in and restore the trashed contact. i think any other specific stuff will involve a fair amount of restructuring to the current code base

lobo

lcdweb · August 24, 2010, 08:52:41 am

X+ -- i don't believe the activity is deleted. it just removes the linked data.

Lobo --
1) will do. the mini-report is the small table above the search results that displays the total, count, and average for the returned contrib records

2) whereas you convinced me last night, i'm not convinced on this one. activities are odd, but simply removing all display of the trashed record creates problems. see this record: http://drupal.demo.civicrm.org/civicrm/contact/view?action=browse&reset=1&cid=102&selectedChild=activity

that's confusing -- the n/a value in the added by field -- and misleading.

i understand the "treat trashed contacts like they're truly deleted" philosophy. but i think the whole point of having the trash is to provide information to users -- in this case, that some related activities have been impacted by the trashing action -- and then give them the chance to do something about it.

couple other trash things coming up:

if a logged in user's contact record was trashed, they're unable to restore it -- it throws an error saying: This contact record is linked to the currently logged in user account - 'Brian Shaughnessy' - and cannot be deleted. (in this case someone else trashed it, but it remained linked to my account, yet I'm unable to restore)

there's a warning showing up on the sandbox when trashing records:
warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in /var/www/drupal.civicrm.org/svn/civicrm32/CRM/Contact/BAO/Contact/Utils.php on line 69.

i know those aren't critical bugs, but just an fyi.

CiviCRM Community Forums (archive)

News:

Author Topic: a couple trashed record issues (Read 649 times)

lcdweb

a couple trashed record issues

xavier

Re: a couple trashed record issues

Donald Lobo

Re: a couple trashed record issues

lcdweb

Re: a couple trashed record issues