CiviCRM Community Forums (archive)

Currently, if I'm an authenticated user, but am NOT in any "Role" that has "Access CiviContribute" checked, I can still see contributions if I go into a contacts activity history. The "Contribution" tab is not visible, but the contributions are still visible if I go to the "Activities" tab! I hacked the source code and wrote a quick and dirty fix to not show contributions under activity history at all, but it's "security by obscurity" and not really a true fix. It also gets blown away every time I do an upgrade. Would be nice to get this cleaned up such that only those who are a member of a group that has "Access CiviContribute" checked can see contributions under the activity tab!

The quick (and I did say "dirty", right?) fix, for those interested is to add:
{if $row.activity_type NEQ "Contribution"}
between line 52, which reads:
{foreach from=$rows item=row}
and line 53, which reads:
<tr class="{cycle values="odd-row,even-row"} {$row.class}">
of templates/CRM/Activity/Selector/Activity.tpl:

Then you'll need a corresponding {/if} between line 109 and line 110

The above line numbers are relevant to civicrm 3.1.4!
Cheers,
Marty.
P.s. I thought I had submitted this a year or two back, but couldn't find it in a search - apologies if you've seen the request in the past.....

OK, I'll take a look when I get a chance. Brings up some interesting questions/issues though:
1. Should we hide ALL contributions from all users in the activity tab, or just hide them from people who don't have that role associated?
2. Hiding contributions screws up the activity record count. The number on the tab will say, for example, 10, but there might only be 7 visible records, as 3 of the contribution records are hidden! I'm guessing if we fix this at the selector/query level as you suggested, then it may automatically fix the count - not sure how the count is determined?? When I originally put my quick and dirty fix in place, I added some text to the page that displays the activity summary that said something like "...There are X number of activity records for this person, but they may not all be visible in this summary" (or something like that anyway). Not really a great solution....