CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Lost search context: CRM-6328
Pages: [1] 2

Author Topic: Lost search context: CRM-6328  (Read 4819 times)

nigel_currie

  • Guest
Lost search context: CRM-6328
October 22, 2010, 05:47:49 am
My client has raised this one with me - the "search results" in the breadcrumb trail is broken when returning from performing a contact task because the qfKey for the search form gets dropped from the session. Hitting "search results" returns a list of all contacts. Further details are in CRM-6328. The issue has been closed, but it's not been fixed as far as I can see. I'm not too confident messing with the core session stuff as I don't fully understand it. Although it's marked as trivial I don't see it as an easy fix and it may be a deal-breaker for my client. Not sure where to go from here, so any advice is appreciated.

We're on CiviCRM 3.2.1

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: Lost search context: CRM-6328
October 22, 2010, 05:52:41 am
trivial isn't about the complexity of the issue, but about its important.

More likely than not, it's simply the default value and the person that filled the issue didn't change it, you shouldn't read more than that in it.

X+
-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

nigel_currie

  • Guest
Re: Lost search context: CRM-6328
October 22, 2010, 05:57:59 am
I realise that trivial in this context means that the impact on functionality is considered trivial. However, the issue is closed and the issue not resoved. I just need to know where I can go from here.

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Lost search context: CRM-6328
October 22, 2010, 07:06:52 am

can you upgrade to 3.2.3 and see if its still broken in that release

alternatively, can u check on the demo server and see if it works there

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

nigel_currie

  • Guest
Re: Lost search context: CRM-6328
October 22, 2010, 07:24:59 am
It's broken on the demo sites too. There's been no work done on this issue since July when it was closed, so it's not surprisingly still broken.

Kiran Jagtap

  • Ask me questions
  • ****
  • Posts: 533
  • Karma: 51
Re: Lost search context: CRM-6328
October 23, 2010, 03:32:09 am
could you please check here : http://drupal.demo.civicrm.org/

and let us know more insight about your test case where context is broken.

thanks

Kiran
You Are Designed To Choose... Defined By Choice.

nigel_currie

  • Guest
Re: Lost search context: CRM-6328
October 27, 2010, 01:44:57 am
Yes, still broken on the Drupal demo site too. Test case steps as follows:
  • perform basic search (Search->Find Contacts) on term "smith" for "name or email"
  • Search returns 7 results. Click on first one (e.g. John Smith)
  • Click "Membership tab"
  • Click view on the one membership that's there and hit "Done"
  • Click "Search Results" in the breadcrumb trail - 176 results are shown (all contacts)

Kiran Jagtap

  • Ask me questions
  • ****
  • Posts: 533
  • Karma: 51
Re: Lost search context: CRM-6328
October 28, 2010, 12:24:38 am
Yep, here if you click on contact name, context is not maitain properly.

Current Context support : When user click on View/ Edit action links, we should get back to proper search result set.
( make sure you are performing actions only on contact object )

Now when u go to contact view page -> further if u click on any child tab, u r changing context from contact object to respective target.
( in your case its a membership ) so you could not able to get back to proper result set, still not implemented.

patch/fix would be welcome to support context when we click on contact name,
u could get the code/logic reference from View/Edit action links.

thanks,

kiran
You Are Designed To Choose... Defined By Choice.

nigel_currie

  • Guest
Re: Lost search context: CRM-6328
October 29, 2010, 10:28:32 am
Thanks.

So CRM-6328 only fixed this at the "contact context" level - if that's the case, do I need to open a new issue for this?

Sounds like this one might be a good entry point for me...

Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: Lost search context: CRM-6328
October 29, 2010, 11:44:38 am

yes, can you please create a new issue for this and attach your patch there

Seems like one potential fix might to to switch the breadcrumb to the regular one rather than the search context one, since now you've gone down into viewing memberships etc

thanx

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

nigel_currie

  • Guest
Re: Lost search context: CRM-6328
November 01, 2010, 05:25:12 am
OK, will do. Since I'm new to development on the official CiviCRM codebase - where is a good place to start to learn about your development process - raising issues, creating patches, unit testing, coding standards, etc.

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: Lost search context: CRM-6328
November 01, 2010, 06:59:47 am
Hi,

For what I got

Few pointers:

http://en.flossmanuals.net/CiviCRM/CiviCommunity

Install from svn

and unit testing: http://wiki.civicrm.org/confluence/display/CRM/CiviCRM+Unit+Testing+basic+information

In general, read the code and hang out on IRC, and come to meetup/ training if you get one around and can afford it.

X+
-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

nigel_currie

  • Guest
Re: Lost search context: CRM-6328
November 01, 2010, 08:01:30 am
Cool, thanks. I'll keep an eye out for upcoming events - I'm in London, so I imagine there'll be a meet coming up in the not too distant...

Is there any Windows/Joomla specific info in installing from svn? Just read through the installion notes on the wiki, but it's kind of Drupal/linux specific (http://wiki.civicrm.org/confluence/display/CRMDOC32/Installing+CiviCRM+from+subversion+%28SVN%29+repository).

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: Lost search context: CRM-6328
November 01, 2010, 08:22:39 am
Quote from: nigel_currie on November 01, 2010, 08:01:30 am
Cool, thanks. I'll keep an eye out for upcoming events - I'm in London, so I imagine there'll be a meet coming up in the not too distant...

Might want to join this group:
http://civicrm.org/groups/uk

I have no idea about Windows/Joomla, I use neither of them.

X+
-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

nigel_currie

  • Guest
Re: Lost search context: CRM-6328
November 04, 2010, 09:47:17 am
Ta. Joined.

Would it be advisable to just check out the CRM + templates folders into an existing Joomla install (as opposed to linking to the source with ln)?
Pages: [1] 2
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Lost search context: CRM-6328

This forum was archived on 2017-11-26.