CiviCRM Community Forums (archive)

I've found an error in 3.3.1 that is reproducible on the demo site. I think I've identified the offending code. Here's how to reproduce:

• create a 'employee of' relationship for an individual
• 'edit' the relationship
• uncheck the 'Enabled?' flag
• click on 'save relationship' and get the following error...

Database Error Code: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3, 1064
Additional Details:

Array
(
    [callback] => Array
        (
            [0 ] => CRM_Core_Error
            [1 ] => handle
        )

    [code ] => -2
    [message] => DB Error: syntax error
    [mode] => 16
    [debug_info] => UPDATE civicrm_contact
SET organization_name=NULL, employer_id = NULL
WHERE id=;  [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3]
    [type] => DB_Error
    [user_info] => UPDATE civicrm_contact
SET organization_name=NULL, employer_id = NULL
WHERE id=;  [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3]
    [to_string] => [db_error: message="DB Error: syntax error" code=-2 mode=callback callback=CRM_Core_Error::handle prefix="" info="UPDATE civicrm_contact
SET organization_name=NULL, employer_id = NULL
WHERE id=;  [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3]"]
)

The workaround is to disable the relationship by setting the end date.

It seems to be related to the following code on line 505ff in CRM/Contact/Form/Relationship.php ...

           //if relationship type change and previously it was
            //employer / emplyee relationship with current employer
            //than clear the current employer. CRM-3235.
            if ( ( CRM_Utils_Array::value( 'current_employee_id', $this->_values ) &&
                  $relationshipTypeId != $this->_values['relationship_type_id'] ) ||
                 ( ! $params['is_active'] ) ) {
                require_once 'CRM/Contact/BAO/Contact/Utils.php';
                CRM_Contact_BAO_Contact_Utils::clearCurrentEmployer( $this->_values['current_employee_id'] );
            }

This code can be called when $params['is_active'] is 'false', irrespective of whether $this->_values['current_employee_id'] has a valid value.

My backtrace is ...

Jan 03 22:41:20  [info] $backTrace = /var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/Error.php, backtrace, 205
, handle,
/var/www/citybibleforum/sites/all/modules/civicrm/packages/PEAR.php, call_user_func, 931
/var/www/citybibleforum/sites/all/modules/civicrm/packages/DB.php, PEAR_Error, 968
/var/www/citybibleforum/sites/all/modules/civicrm/packages/PEAR.php, DB_Error, 564
/var/www/citybibleforum/sites/all/modules/civicrm/packages/DB/common.php, raiseError, 1903
/var/www/citybibleforum/sites/all/modules/civicrm/packages/DB/mysql.php, raiseError, 898
/var/www/citybibleforum/sites/all/modules/civicrm/packages/DB/mysql.php, mysqlRaiseError, 327
/var/www/citybibleforum/sites/all/modules/civicrm/packages/DB/common.php, simpleQuery, 1216
/var/www/citybibleforum/sites/all/modules/civicrm/packages/DB/DataObject.php, query, 2421
/var/www/citybibleforum/sites/all/modules/civicrm/packages/DB/DataObject.php, _query, 1607
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/DAO.php, query, 145
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/DAO.php, query, 868
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Contact/BAO/Contact/Utils.php, executeQuery, 391
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Contact/Form/Relationship.php, clearCurrentEmployer, 512
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/Form.php, postProcess, 250
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Upload.php, mainProcess, 153
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Upload.php, realPerform, 130
/var/www/citybibleforum/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php, perform, 203
/var/www/citybibleforum/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php, handle, 103
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/Controller.php, handle, 284
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Contact/Page/View/Relationship.php, run, 215
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Contact/Page/View/Relationship.php, edit, 252
/var/www/citybibleforum/sites/all/modules/civicrm/CRM/Core/Invoke.php, run, 219
/var/www/citybibleforum/sites/all/modules/civicrm/drupal/civicrm.module, invoke, 356
, civicrm_invoke,
/var/www/citybibleforum/includes/menu.inc, call_user_func_array, 348
/var/www/citybibleforum/index.php, menu_execute_active_handler, 18

Hey! Great service!

I commented on the forums, Sushant fixes the issue, and it's released as part of 3.3.2 within 48 hours!

Nice,

Ken