CiviCRM Community Forums (archive)

I think I've found a defect in 3.3.2. It is reproducible on the 3.3 demo.

Steps to reproduce.

• Create a profile which includes the Contribution Source field
• Create a contribution page which includes that profile and allows pay later contributions
• Create a contribution that is "pay now" and enter a value for the Contribution Source
• This works as expected: the contribution and the receipt show the entered source
• Create a contribution that is "pay later" and enter a value for the Contribution Source
• This fails - the source reverts to the default: "Online Contribution: <page title>"

See the first comment below for a patch.

The problem lies in CRM/Contribute/BAO/Contribution/Utils.php and is due to the 'source' variable not being set equal to the 'contribution_source' before the contribution is processed via CRM_Contribute_Form_Contribution_Confirm::processContribution.

This is the case that works, on lines 236-252, and 'source' is set beforehand ...

           if ( isset( $paymentParams['contribution_source'] ) ) {
                $form->_params['source'] = $paymentParams['contribution_source'];
            }
            
            // check if pending was set to true by payment processor
            $pending = false;
            if ( CRM_Utils_Array::value( 'contribution_status_pending',
                                         $form->_params ) ) {
                $pending = true;
            }
            if ( !($paymentParams['is_recur'] && $form->_contributeMode == 'direct') ) {
                $contribution =
                    CRM_Contribute_Form_Contribution_Confirm::processContribution( $form,
                                                                                   $form->_params, $result,
                                                                                   $contactID, $contributionType,
                                                                                   true, $pending, true );
            }

This is the code that fails, on lines 102-142. Not only is $paymentParams['contribution_source'] copied *after* the payment is processed, but it is copied into $form->_params['source'] (if the cases are symmetrical it should be copied into $paymentparams['source'] since that is the argument to processContribution()) ...

           $contribution =
                CRM_Contribute_Form_Contribution_Confirm::processContribution(
                                                                              $form,
                                                                              $paymentParams,
                                                                              null,
                                                                              $contactID,
                                                                              $contributionType,
                                                                              true, true, true );
            $form->_params['contributionID'    ] = $contribution->id;
            $form->_params['contributionTypeID'] = $contributionType->id;
            $form->_params['item_name'         ] = $form->_params['description'];
            $form->_params['receive_date'      ] = $now;
            
            if ( $form->_values['is_recur'] &&
                 $contribution->contribution_recur_id ) {
                $form->_params['contributionRecurID'] = $contribution->contribution_recur_id;
            }
            
            $form->set( 'params', $form->_params );
            $form->postProcessPremium( $premiumParams, $contribution );
          
            if ( $form->_values['is_monetary'] && $form->_amount > 0.0 ) {
                // add qfKey so we can send to paypal
                $form->_params['qfKey'] = $form->controller->_key;
                if ( $component == 'membership' ) {
                    $membershipResult = array( 1 => $contribution );
                    return $membershipResult;
                } else {
                    if ( ! $form->_params['is_pay_later'] ) {
                        $result =& $payment->doTransferCheckout( $form->_params, 'contribute' );
                    } else {
                        // follow similar flow as IPN
                        // send the receipt mail
                        $form->set( 'params', $form->_params );
                        if ( $contributionType->is_deductible ) {
                            $form->assign('is_deductible',  true );
                            $form->set('is_deductible',  true);
                        }
                        if( isset( $paymentParams['contribution_source'] ) ) {
                            $form->_params['source'] = $paymentParams['contribution_source'];
                        }