CiviCRM Community Forums (archive)

Hi,

Just talked with X about the 'verify mandatory' when we want to ensure x or y is present.

I modified civicrm_verify_mandatory (v3) in the api branch http://svn.civicrm.org/civicrm/branches/trunk.api/api/v3 so that it accepts

$keys = array('id',
                     array('contact_id', 'contact_b'));

to denote that required fields are 'id' AND ('contact_id' OR 'contact_b')

There is a wrapper

function civicrm_verify_one_mandatory

that apparently makes it easier if you are just passing 'x' or 'y'

(X said it would & it seemed easy enough to do)

Note that for GET functions the $daoName should be left as null

So, the function now starts

function civicrm_tag_get($params)
{   
   try {

    civicrm_verify_one_mandatory (&$params, null, array('id', 'name')); 
    _civicrm_initialize( );
Can we leave     _civicrm_initialize( ); until after the verification? If so it would be more efficient. Seems to work

Can we leave     _civicrm_initialize( ); until after the verification? If so it would be more efficient. Seems to work

I'd argue that optimising the failure path (that shouldn't be taken anyway) isn't the path we should worry about performance.

Better leave it at the top, later we might need it within the verify_mandatory for whatever wicked reason that will come up (eg. that the mandatory params depend on the user access right...).

If calling the api with a wrong param takes a few ms more than the optimal solution ot return an error, so be it.

X+

OK - cool - I notice a comment from Coleman on the wiki page about us needing to make sure civicrm_initialize is in all functions - so will do it as I see it