CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion »
  • APIs and Hooks (Moderator: Donald Lobo) »
  • The love list
Pages: [1]

Author Topic: The love list  (Read 695 times)

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
The love list
February 05, 2011, 02:05:47 pm
So, as you are probably aware I've been focussing on the more superficial aspects and many api have fallen into line just by adding a few std things at the beginning & end of functions. However, there are few functions that will take a bit more to bring them into line so I thought I'd start listing the API that need the most love - at this stage I'm looking at

Relationship
Constant

as being the ones that don't want to accept an array and don't suggest an quick fix (constant is probably in terms of the output althought the array could be always sequential)

Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

xavier

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4453
  • Karma: 161
    • Tech To The People
  • CiviCRM version: yes probably
  • CMS version: drupal
Re: The love list
February 06, 2011, 12:27:36 am

Relationship get seems to be returning the right thing (no sequential aside ;)
http://api.crm/civicrm/ajax/rest?json=1&debug=1&version=3&entity=Relationship&action=get&contact_id=1
-Hackathon and data journalism about the European parliament 24-26 jan. Watch out the result

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: The love list
February 06, 2011, 01:36:52 am
now it does sequential

       return civicrm_create_success( $relationships ,$params);

(was        return civicrm_create_success( $relationships);

but yeah - let me check why it's failing so much

CustomGroup.php::civicrm_custom_group_create seems to take an odd input format - a nested array from the looks of it & to have some backwards compatibility that should go
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: The love list
February 10, 2011, 12:23:44 pm
Ok - the test report is a pretty good clue as to which need love but I noticed group_contact is a bit non standard - because it has different statuses
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion »
  • APIs and Hooks (Moderator: Donald Lobo) »
  • The love list

This forum was archived on 2017-11-26.