Author Topic: token hook: how do you know when to calculate? (Read 942 times)

xavier · March 01, 2011, 10:59:13 pm

Hi,

The hook to calculate the values of custom token has two params:
an array of contacts
and array of contacts id

1) What is the purpose of the second param, as the array of contacts already uses the id as the key, and has a contact_id as well?

2) How do you know what token are in the mail?
ie. I wouldn't want to fire lots of complicated requests for my complicated token if it isn't used. For what I've tested, it is called everytime, even if the token isn't in the mail.

X+

Eileen · March 01, 2011, 11:01:29 pm

erm subscribing ... both things I have wondered about. I did see something in the code that suggested they aren't always called in all circumstances but I didn't get a real grip on it.

I had thought to publish a module with a sort of pluggable token system but never got there & haven't been hassled about tokens lately...

SarahG (FountainTribe) · March 02, 2011, 07:55:42 am

I have noticed the same issue with the custom tokens. I have some custom tokens that are expensive to calculate, and it would be great if they were not calculated needlessly.

Donald Lobo · March 02, 2011, 08:13:23 am

1. sending the contactIDs is redundant. I think we sent it to the hook, because we had it lying around and were using it in the queries

2. would be good to send the list of tokens (if any) used in that mail (as an optional 4th parameter). Anyone want to take a look and contribute a patch. U'll need to fix all the place where we call

CRM_Utils_Hook::tokenValues

You can get the tokens for a mailing object using:

$mailing->getTokens( );

lobo

CiviCRM Community Forums (archive)

News:

Author Topic: token hook: how do you know when to calculate? (Read 942 times)

xavier

token hook: how do you know when to calculate?

Eileen

Re: token hook: how do you know when to calculate?

SarahG (FountainTribe)

Re: token hook: how do you know when to calculate?

Donald Lobo

Re: token hook: how do you know when to calculate?