CiviCRM Community Forums (archive)

I feel that with Option_Value_Get over half the time people would know the option_group_name & need to get the option_group_id so I think it would be good to think about accepting option_group_name as a parameter for it (& think about how that would look)

civicrm_api('OptionValue','Get', array(option_group_name =''activity_type"));

This being said, we can keep a simple wrapper

civicrm_api3_activity_type_get ($params) {
  return civicrm_api('OptionValue','Get', array(option_group_id = 2));
}

No idea what constant does

At the moment I expect you can't pass option_group_name to option_value_get? I'm assuming it only accepts option_group_id?

Indeed.

As for the wrapper vs. not wrapper, the issue is that you are exposing how stuff are being implemented. ie if tomorrow ActivityType gets a hierarchy or ACL, it will likely move to its own table. Shouldn't be a concern for the calling party of the API.

What about having a generic wrapper for options?

The issue will be to document, have to have a look at your generate function.

Or may be we keep that option for the next release and focus on finish what's on the table...

X+

Ok, let's take it out, if we re-introduce it, that will be in a generic manner.

Still don't know what constant does

X+

Hi,

Looked, some (eg list of countries) are not in the OptionValues. I fixed so the param is a single array, tested on civicrm/ajax/doc.

I fixed some of the tests. Some others will never work, eg:

        $parameters = array( true, false, true );
        $result = civicrm_api3_constant_get( 'activityType', $parameters );

I'm not familiar enough with the morse code to know what that param means, but it won't fit into api v3.

I'd suggest to say that Constant get in v3 only works with name= 'TheTypeOfPseudoConstant' as the only accepted param), the extra param are going to come back as soon as someone figure out what it's supposed to mean, translate that into a human readable associative array, submit a patch and a test suite. but after v3.

If ok, I suppress the tests with the extra params.


Constant solved!

Was already done. Or do you mean adding a test ?

function civicrm_api3_constant_get($params = array())
{
  _civicrm_api3_initialize(true);
  try{
    civicrm_api3_verify_mandatory ($params,null,array ('name'));
    $name= $params ['name'];

Kill ActivityType, I know you want it

I fixed the tests