CiviCRM Community Forums (archive)

As far as I know the only way to import contributions as pledge payments is through the api/ a script. I do have code that I use for this (in conjunction with the migrate module)

The problem is due to a difference between API v2 and v3.

The following patch fixes the problem. I've taken the liberty of filing issue CRM-7994 for this.

--- /data/Download/CiviCRM/civicrm-3.4.0-drupal/CRM/Contribute/Import/Parser/Contribution.php   2011-03-15 08:49:22.000000000 +1100
+++ /var/www/xxx/sites/all/modules/civicrm/CRM/Contribute/Import/Parser/Contribution.php        2011-04-29 13:51:06.978431381 +1000
@@ -455,7 +455,8 @@
                     }
                     
                     $this->_newContributions[] = $newContribution['id'];
+                    $formatted['contribution_id'] = $newContribution['id'];
                                       
                     //return soft valid since we need to show how soft credits were added
                     if ( CRM_Utils_Array::value( 'soft_credit_to', $formatted ) ) {
                         return CRM_Contribute_Import_Parser::SOFT_CREDIT;
@@ -523,7 +524,8 @@
             }
             
             $this->_newContributions[] = $newContribution['id'];
+            $formatted['contribution_id'] = $newContribution['id'];
                     
             //return soft valid since we need to show how soft credits were added
             if ( CRM_Utils_Array::value( 'soft_credit_to', $formatted ) ) {
                 return CRM_Contribute_Import_Parser::SOFT_CREDIT;

The API call eventually invokes CRM_Contribute_BAO_Contribution::create(). On line 226 of that file the $params argument is modified ...

        $params['contribution_id'] = $contribution->id;

In v2, that change to the array filters back to the caller of the API, but this doesn't happen in v3.

This issue raises the wider questions ...

• Does this fix need to be applied in other cases?
• Should the API pass back changes in it's arguments to the caller?

Ken

NB - if you call

api v3 create & create one item the id will be returned e.g

$result = ('Contribution','Create',$params);
echo $result['id'] ;

will give the id of the contribution just created -so perhaps you don't need the other now?

This has been the topic of some discussion - officially the params object shouldn't be changed by the api but there are still some cases where it happens....

Well, now $params is by value, so pretty much sure it is enforced

The problem. as ken have identified (many thanks) is that the api v2 did modify the param, and the calling code was expecting it. That's the kind of bug/intended side effect that is difficult to spot while porting to api v3.