CiviCRM Community Forums (archive)

the Membership API function can create a new membership or if you pass in a membership ID it will update an existing membership.
That works for a straight renewal but you have to calculate the new dates to pass in.   

Would it be possible to borrow more from the renewMembership code in CRM/Member/BAO/Membership.php to let this function (or perhaps a new function) handle renewals with upsell?  if params includes  membershipTypeID update the appropriate membership  (if in the same organization) or create a new membership  if none exist in the organization?

I would like to call this from a drupal module (uc_civicrm_products). the current renewMembership function has the contribution page form ogject as a required argument, which is not necessary from my usage.  (I have verified that removing the references to the form object the rest of teh code will create memberships)  I've been recoding using the API calls, but find that I am reinventing the code that is in the renew membership function already.  As one would like the extension to Drupal to have the same functionality as the civcrm methods,  having a public version of that would be really usefull!

Thanks!
Merlise

tip: use civicrm/ajax/doc to test (easier than to run unit tests)

Nah - write a test to test because then you have a working test @ the end + you wind up writing tests for all the odd scenarios you hit along the way. It's more robust!

NB - there's another thread on the forum (will have to search) where we decide the syntax for options & things but I think it would be

$params['option.member_upsell'] = 1;

if you want to create a specific optional behaviour

Hi Lobo,

I seem to keep hitting this problem of code being a bit too integrated with the forms rather than being standalone in the BAO (I think payment processor :: create was an example I hit recently). Is there a policy to try to move functionality/ put new functionality into BAO functions instead of in the forms or am I just being hopeful.

here is the part of  how I coded  the create/renew/upgrade in the uc_civicrm_products module  (the input will be contact_id, membership_type_id :  (Note: the current BAO function doesn't restrict upsell to within an organization yet so results will be different)

(apologies in advance for coding -- this is my first foray into php programming! so suggestions are welcome)



case 'civimember':
   require_once 'CRM/Core/BAO/CustomField.php';
   require_once 'CRM/Member/BAO/Membership.php';
    require_once 'CRM/Member/BAO/MembershipType.php';
    require_once 'api/v2/Membership.php';
    require_once 'api/v2/Contact.php';
    require_once 'CRM/Utils/Hook.php';

 // purchased membershiptype
   $membershipTypeID = $data['membership_type_id'];

  // get details of organization for new membership.

   $memtyp_id['id'] = $membershipTypeID;
   $newMembershipDetails = & civicrm_membership_types_get($memtyp_id);
   $new_org =  $newMembershipDetails[$membershipTypeID]['member_of_contact_id'];
   $org_params = array('contact_id' => $new_org);
   $org_contact = & civicrm_contact_get($org_params);
   $organization_name = $org_contact[$new_org]['display_name'];
 
  // now get contact's memberships
  $params = array('contact_id' => $contact_id,);
  $existMembership = &  civicrm_membership_contact_get($params);
  $existMembership = $existMembership[$contact_id];

// remove  pending and cancelled memberships  do not update those
   foreach($existMembership as $key => $value) {
     if (in_array('Pending',$value) ||  in_array('Cancelled', $value)) {
         unset($existMembership[$key]); }
}   

//  sort by end_date to find most recent first  desc and then membership type asc
   $sortkeys = array();
   foreach($existMembership as $k=>$v) {
       $sortkey['membership_type_id'][$k] = $v['membership_type_id'];
       $sortkey['end_date'][$k] = $v['end_date'];
}
   array_multisort($sortkey['end_date'], SORT_DESC, $sortkey['membership_type_id'], SORT_ASC, $existMembership);

//  for each membership_id find memberhip type's organization
//  id in membdata is membership_id; civicrm_membership_typeS_ gets
//    needs the id of membership types

   $membership_to_update = null;
   $renewal = FALSE;
    foreach ( $existMembership as $key => $memdata) {
     $memtyp_id = array('id' => $memdata['membership_type_id']);
     $temp = & civicrm_membership_types_get($memtyp_id);
     if ($new_org ==
$temp[$memdata['membership_type_id']]['member_of_contact_id']) {
     $membership_to_update = $memdata['id'];
     $renewal = TRUE;
     break;}
     }
   
   $params['membership_type_id'] = $membershipTypeID;
   if (! $renewal) {//  no memberships of that organization create new
      $params['join_data'] =  date('Ymd');
      // have civi calculate dates for membership.
      $calcDates = CRM_Member_BAO_Membershiptype::getDatesForMembershipTypE($params['membership_type_id'],     $params['join_date'], $params['start_date']);
      $params = array_merge($params, $calcDates);
      $params['source'] =  'Online Contribution: ' . $organization_name . ' New Member Dues';
      $api_results[$fid] =& civicrm_contact_membership_create($params);
      }
 // renew or upsell
else {         
    $calcDates =
    CRM_Member_BAO_MembershipType::getRenewalDatesForMembershipType(  $membership_to_update, null, $membershipTypeID );
     $params = array_merge($params, $calcDates);
     $params['id'] = $membership_to_update;
     $params['source'] =  'Online Contribution: '  .  $organization_name
        . ' Dues Renewal';
     $api_results[$fid] =& civicrm_contact_membership_create($params);

 }
//    else { $cid = 20;    test using this contact page
//      require_once 'CRM/Contribute/BAO/ContributionPage.php';
 //     $civiform =  CRM_Contribute_BAO_ContributionPage::copy($cid);
//  _civicrm_object_to_array(CRM_Member_BAO_Membership::renewMembership($contact_id,            $membershipTypeID, $is_test, $civiform, date('YmdHis'), null,null ),  $membership);
 //    $membership['source'] = 'civi code';
 //    $api_results[$fid] =  $membership;
 //   }

            break;