CiviCRM Community Forums (archive)

Yeap, the pre/post hooks should be in the DAO to avoid all that.

What about

1) the hook is modified to set a $already_called [$hook][$action][$objectName][] = $id

and add in the DAO.php in the functions that test if the BAO has properly called the hook and calls it if not:

if (empty ( $already_called [$hook][$action][$objectName][$id])) {
        require_once 'CRM/Utils/Hook.php';
        CRM_Utils_Hook::pre( 'delete', 'Tag', $id, $tag );

        if ( $tag->delete( ) ) {
            CRM_Utils_Hook::post( 'delete', 'Tag', $id, $tag );
            CRM_Core_Session::setStatus( ts('Selected Tag has been Deleted Successfuly.') );
            return true;
        }


I'm not a big fan of yet another global variable, but we can't rely because some BAO don't use the parent DAO function but instanciate a new DAO (for some reason), eg for Tag BAO:


    static function del ( $id ) {
...

        // delete from tag table
        $tag = new CRM_Core_DAO_Tag( );
        $tag->id = $id;

        require_once 'CRM/Utils/Hook.php';
        CRM_Utils_Hook::pre( 'delete', 'Tag', $id, $tag );

        if ( $tag->delete( ) ) {
            CRM_Utils_Hook::post( 'delete', 'Tag', $id, $tag );
            CRM_Core_Session::setStatus( ts('Selected Tag has been Deleted Successfuly.') );
            return true;
        }
        return false;



The DAO has only the _tableName (eg. civicrm_tag), but I'm assuming that's trivial to add the name of the Entity/$objectName .