CiviCRM Community Forums (archive)

Hi,

On the of the issue we have is that when you have an error, you need to parse error_message to handle it. And based on my experience with unit testing, not the most reliable way of testing

We can provide an additional optional param to civicrm_api3_create_error, and I have started providing an error_type when I was working on the generic getsingle action

so
civicrm_api3_create_error("Expected one $entity but found " .$result['count'], array ('error_type' => 'too_many_results', 'count'=>$result['count']))

will generate:
{
"is_error":1,
"error_message":"Expected one Contact but found 4",
"error_type":"too_many_results",
"count":4
}

Suggested syntax: set "error_type", value only lower case string and underscore.

I'd suggest to test on error_type (and other optional fields returned if needed) instead of parsing the error_message (that is made to be displayed), eg in phpunit too

What do you think ?

X+

I'll extends the exception class to make use of that for the "generic" errors.