CiviCRM Community Forums (archive)

Hi,

The presenting problem (in 3.4.1, code seems the same in 3.4.4) was that in the My Cases / All Cases listings on the case dashboard, the "more" link brought up an empty list, except for uid 1 where the list had "Assign to Another Client". I tracked this down to CRM_Case_BAO_Case::getCases, around line 732:

        // check is the user has view/edit signer permission
        $permissions = array( CRM_Core_Permission::VIEW );
        if ( CRM_Core_Permission::check( 'edit cases' ) ) {
            $permissions[] = CRM_Core_Permission::EDIT;
        }
        if ( CRM_Core_Permission::check( 'delete in CiviCase' ) ) {
            $permissions[] = CRM_Core_Permission::DELETE;
        }
        $mask = CRM_Core_Action::mask( $permissions );

The permission 'edit cases' is not defined by CiviCRM. These are all the occurrences of 'edit cases' in the Civi tree:

./CRM/Case/Task.php:             || CRM_Core_Permission::check( 'edit cases' ) ) {
./CRM/Case/Selector/Search.php:         if ( CRM_Core_Permission::check( 'edit cases' ) ) {
./CRM/Case/BAO/Case.php:        if ( CRM_Core_Permission::check( 'edit cases' ) ) {

CRM_Case_Info::getPermissions just has:

    public function getPermissions()
    {
        return array( 'delete in CiviCase',
                      'administer CiviCase',
                      'access my cases and activities',
                      'access all cases and activities' );
    }

Adding 'edit cases' here and granting to the appropriate roles allows the "Assign to Another Client" link to appear.

It also seems like a UI glitch that  the "more" link appears but brings up an empty list when there are no actions to show.

Dave J

Hi Dave,

In CRM/Case/BAO/Case.php getCases(), we have variable $allCases so I've done this:

--- Case.php.orig       2011-06-12 17:15:28.000000000 +0100
+++ Case.php    2011-06-29 17:41:23.000000000 +0100
@@ -731,7 +731,8 @@
         
         // check is the user has view/edit signer permission
         $permissions = array( CRM_Core_Permission::VIEW );
-        if ( CRM_Core_Permission::check( 'edit cases' ) ) {
+        if ( CRM_Core_Permission::check( 'access all cases and activities' ) ||
+             (!$allCases && CRM_Core_Permission::check( 'access my cases and activities' )) ) {
             $permissions[] = CRM_Core_Permission::EDIT;
         }
         if ( CRM_Core_Permission::check( 'delete in CiviCase' ) ) {

In CRM/Case/Selector/Search.php getRows(), it's not clear whether 'access all cases and activities' or 'access my cases and activities' is appropriate, as it will depend on the cases being retrieved. Should the permissions mask therefore be calculated separately per case, using the 'all' or 'my' permission depending on whether the case belongs to the user?

In CRM/Case/Task.php permissionedTaskTitles(), accept either permission?

Dave J

Hi Dave,

Thanks, I've submitted issue CRM-8411 with patch.

Dave J