Author Topic: label or name for unique index for civicrm_custom_field? (Read 834 times)

JoeMurray · July 14, 2011, 05:34:24 pm

It seems to me that the unique key for custom fields should be based on the name rather than the label, since the name is what is used internally as a programmatic reference. If not, we should drop name. I haven't checked other similar tables, but this seems incorrect to me. Should I post a patch?

<index>
<name>UI_label_custom_group_id</name>
<fieldName>label</fieldName>
<fieldName>custom_group_id</fieldName>
<unique>true</unique>
<add>1.1</add>
</index>

xavier · July 14, 2011, 10:20:19 pm

I think you are right and should submit a patch.

However, as the name is generated by the label and not exposed in the UI, won't probably make a big difference.

X+

JoeMurray · July 15, 2011, 08:04:05 am

I'll submit a patch. The name is 64 chars, and is set once, and the label is 255 and can be changed through the interface without that affecting the name.

JoeMurray · July 15, 2011, 08:53:34 am

CRM-8507

CiviCRM Community Forums (archive)

News:

Author Topic: label or name for unique index for civicrm_custom_field? (Read 834 times)

JoeMurray

label or name for unique index for civicrm_custom_field?

xavier

Re: label or name for unique index for civicrm_custom_field?

JoeMurray

Re: label or name for unique index for civicrm_custom_field?

JoeMurray

Re: label or name for unique index for civicrm_custom_field?