CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Reports with custom data require "access all custom data" (CRM-7153)
Pages: [1]

Author Topic: Reports with custom data require "access all custom data" (CRM-7153)  (Read 953 times)

TwoMice

  • I post frequently
  • ***
  • Posts: 214
  • Karma: 16
    • Emphanos
  • CiviCRM version: Always current stable version
  • CMS version: Drupal 7
Reports with custom data require "access all custom data" (CRM-7153)
July 19, 2011, 12:09:04 pm
Since v.3.3.0, any user without "access all custom data" permission will not be able to see any custom data in a report. (This was the solution implemented for CRM-7153.)

I'd like to see about adding some real ACL checking here, so that the user can access all the custom data, and only the custom data, that they're allowed to by ACLs.  Is this reasonable?

Thanks,
Allen
Please consider contributing to help improve CiviCRM with the Make it Happen! initiative.

Dave Greenberg

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 5760
  • Karma: 226
    • My CiviCRM Blog
Re: Reports with custom data require "access all custom data" (CRM-7153)
July 20, 2011, 10:20:37 am
 Allen - If I understand your proposal, it is to make the permission checking in reports more intelligent so that the report codes uses the same permission checks as other parts of the UI. Users can access report custom data either because they have 'access all custom data' permission OR they have permission for a specific custom data set via ACL.

This seems like an appropriate and useful improvement.
Protect your investment in CiviCRM by  becoming a Member!

TwoMice

  • I post frequently
  • ***
  • Posts: 214
  • Karma: 16
    • Emphanos
  • CiviCRM version: Always current stable version
  • CMS version: Drupal 7
Re: Reports with custom data require "access all custom data" (CRM-7153)
July 20, 2011, 11:07:06 am
You read me right, Dave. Thanks for the encouragement. I'm not sure how easy it will be, but it seems worth doing so far.  I'll try to post an issue with patch soon.

Thanks,
Allen
Please consider contributing to help improve CiviCRM with the Make it Happen! initiative.

Parvez

  • I post occasionally
  • **
  • Posts: 91
  • Karma: 7
Re: Reports with custom data require "access all custom data" (CRM-7153)
April 18, 2012, 03:35:37 am
Hey Allen

Was this ever implemented?

Thanks

TwoMice

  • I post frequently
  • ***
  • Posts: 214
  • Karma: 16
    • Emphanos
  • CiviCRM version: Always current stable version
  • CMS version: Drupal 7
Re: Reports with custom data require "access all custom data" (CRM-7153)
April 18, 2012, 07:07:08 am
Hi Parvez,

No, this one never got off the ground.  I'm not able to work on it at the moment, unfortunately.  So currently it's just in the "good idea" stage.

- A.
Please consider contributing to help improve CiviCRM with the Make it Happen! initiative.

Parvez

  • I post occasionally
  • **
  • Posts: 91
  • Karma: 7
Re: Reports with custom data require "access all custom data" (CRM-7153)
April 18, 2012, 07:23:20 am
Thanks for the info. I'll see if we can get this moving here, dont suppose you have an idea about the amount of effort required?

TwoMice

  • I post frequently
  • ***
  • Posts: 214
  • Karma: 16
    • Emphanos
  • CiviCRM version: Always current stable version
  • CMS version: Drupal 7
Re: Reports with custom data require "access all custom data" (CRM-7153)
April 18, 2012, 07:56:57 am
I would start in CRM_Report_Form::addCustomDataToColumns(), and actually that might be enough right there.  Let me know how it goes!
Please consider contributing to help improve CiviCRM with the Make it Happen! initiative.

Parvez

  • I post occasionally
  • **
  • Posts: 91
  • Karma: 7
Re: Reports with custom data require "access all custom data" (CRM-7153)
April 18, 2012, 08:08:37 am
Ok, Thanks. I'll have a look and see how it goes.

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Developer Discussion (Moderator: Donald Lobo) »
  • Reports with custom data require "access all custom data" (CRM-7153)

This forum was archived on 2017-11-26.