CiviCRM Community Forums (archive)

pretty sure that scenario was not considered when we did relationships

if you can check th code and see where we do the end date check and patch that would be great

note that we should allow the possibility of a null start date and/or a null end date (in which case the dates are ignored)

lobo

I implemented the patch i CRM-8997 but did not see any effect in contact relationship tab. So I did some changes in link_to_original_code/CRM/Contact/BAO/Relationship.php:

static function makeURLClause( $contactId, $status, $numRelationship, $count, $relationshipId, $direction )
...
       if ( $status == self::PAST ) {
            //this case for showing past relationship
            $where .= ' AND civicrm_relationship.is_active = 1 ';
            $where .= " AND civicrm_relationship.end_date < '" . $date . "'";
        } else if ( $status == self::DISABLED ) {
            // this case for showing disabled relationship
            $where .= ' AND civicrm_relationship.is_active = 0 ';
        } else if ( $status == self::CURRENT ) {
            //this case for showing current relationship
            $where .= ' AND civicrm_relationship.is_active = 1 ';
            $where .= " AND (civicrm_relationship.end_date >= '" . $date . "' OR civicrm_relationship.end_date IS NULL) ";
+          $where .= " AND (civicrm_relationship.start_date < '" . $date . "' OR civicrm_relationship.start_date IS NULL) ";
        } else if ( $status == self::INACTIVE ) {
            //this case for showing inactive relationships
            $where .= " AND (civicrm_relationship.end_date < '" . $date . "'";
+          $where .= " OR civicrm_relationship.start_date > '" . $date . "'";
            $where .= ' OR civicrm_relationship.is_active = 0 )';
        }

And also the inherited memberships also stands as valid regardless of the start date (as long as the relationship is set to active). What exactly did the patch for CRM-8997 do?

That's a good idea, Lobo!

A thing that comes to my mind is the membership status. It seems like for inherited membership the status, start and end dates (maybe all of it) is always the same as the primary membership. But for the inherited membership it would be better/more clearer if this was the same as the corresponding relationship values. E.g.
  * create a inherited membership when the relationship is created/activated
  * always keep membership start and end date in sync with the corresponding relationship fields (and that means the membership status would be right as well)
  * only delete inherited membership when either relationship is deactivated/deleted or primary membership is deleted
Of course this above cannot be has to be checked with the primary membership (the start date of a inherited membership cannot be earlier than the primary membership and so on...).

This way the memberships details is more correct IMO because the inherited membership was not started/ended until the relationship was started/ended. I am now trying to think as my client (CiviCRM user) not as a myself (system architect/developer)  What do you think?

I run bin/UpdateMembershipRecord.php on a daily basis in cron to update memberships status (based on status rules). So for me this script feels like a natural candidate for the job if this above should be true. But I run 4.07 so I guess I may already be a bit old-fashioned...

// Jonas

Hi,

There is a cronjob called "Disable expired relationships". Do you run it daily?

X+

Hi again!

I have had my own patch (described above at 15 nov 2012) and it works well for searching and showing relationships as active/inactive correctly according to start/end dates. But still the membership dates is not showed correctly. And I guess they will not be correct even if I would upgrade and start running the new job?

The membership date and status should not be inherited from the primary contact at least not showed on the related contacts membership tab as they are not correct. The inherited membership should have same dates as the relationship, shouldn't it? A inherited membership can't start before the relationships were created/activated and can't be active after the relationship end date, correct?

My client wants to register relationships in advance with start dates in the future. But when they do an active membership turns up with start date several years back (because primary member have been member for several years). This is very misleading!

If I have understood this correctly a new record in civicrm_membership is created with the field owner_membership_id set to the primary member's contact id. So I guess there is nothing keeping us from setting different start and end dates for the inherited memberships as they have it's own record? And then the update_membership_status job can do it's thing and set the correct status.

Could it be a good idea to change the code that creates inherited memberships to register relationships creation/start date and either relationship or primary membership end date (whichever is the earliest) into the inherited membership record?

// Jonas