CiviCRM Community Forums (archive)

Hi,

I'd like to propose the followin patch to make it possible to improve receipts here. The patch basically says "If the event is a paid event & the participant is pending assign the token 'payment_outstanding' to denote it isn't yet paid AND assign the token 'pay_later_receipt'"

I didn't go with 'is_pay_later' because often the records are 'pending due to incomplete transaction'.

I'm thinking we could assign the tokens in the first instance & later build up template logic as people elaborate on use cases. i.e in the cases I deal with we either have their money or we want the 'receipt' to be an invoice but I'm aware there are more complex scenarios like waitlists.


Index: CRM/Event/Form/Participant.php
===================================================================
--- CRM/Event/Form/Participant.php   (revision 36508)
+++ CRM/Event/Form/Participant.php   (working copy)
@@ -1543,7 +1543,6 @@
                 $this->assign( 'participantID', $participants[$num]->id );
 
                 $this->_id = $participants[$num]->id;
-               
                 if ( $this->_isPaidEvent ) {
                     // fix amount for each of participants ( for bulk mode )
                     $eventAmount = array();
@@ -1557,8 +1556,20 @@
                     //So we have to build amount as array.
                     $eventAmount = array_merge( $eventAmount, $additionalParticipantDetails );
                     $this->assign( 'amount', $eventAmount );
+                                 
+                                    require_once 'CRM/Event/PseudoConstant.php';
+                                    $participantStatuses = CRM_Event_PseudoConstant::participantStatusClass();
+                                    if($participantStatuses[$this->_statusId] == 'Pending'){
+                                      $this->assign('payment_outstanding', 1);
+                                    }
+                                    if ( $this->_eventId ) {
+                                      $returnProperties = array( 'pay_later_receipt' );
+                                      $eventdetails = array( );
+                                      CRM_Core_DAO::commonRetrieveAll( 'CRM_Event_DAO_Event', 'id', $this->_eventId, $eventdetails, $returnProperties );
+                                      $this->assign('pay_later_receipt',$eventdetails[$this->_eventId]['pay_later_receipt']);
+
+                                    }
                 }
-
                 $sendTemplateParams = array(
                     'groupName' => 'msg_tpl_workflow_event',
                     'valueName' => 'event_offline_receipt',

Ok looks like on the event side of things it looks like only the contribution status is of interest - I tried assigning payment_outstanding but maybe we should just assign it as contribution_status & then people can build up logic like

{if !$contributionStatus || $contributionStatus eq 2}
This is an Invoice and either no contribution has been recorded against the membership or one has been & it's status is Pending so you need to send us money{/if}

Patch below also fixes inconsistent assignment of membership_id on back end receipts.

Index: CRM/Member/Form/Membership.php
===================================================================
--- CRM/Member/Form/Membership.php   (revision 36549)
+++ CRM/Member/Form/Membership.php   (working copy)
@@ -1438,7 +1438,7 @@
             }
             $this->assign( 'module', 'Membership' );
             $this->assign( 'contactID', $this->_contactID );
-            $this->assign( 'membershipID', CRM_Utils_Array::value('membership_id', $params) );
+            $this->assign( 'membershipID', CRM_Utils_Array::value('membership_id', $params,CRM_Utils_Array::value('membership_id',$this->_defaultValues) ) );
             $this->assign( 'contributionID', isset($contribution)? $contribution->id : null );
             $this->assign('receiptType', 'membership signup');
             $this->assign( 'receive_date', CRM_Utils_Array::value('receive_date', $params) );           
@@ -1451,7 +1451,10 @@
             }
 
             $this->assign( 'customValues', $customValues );
-
+            $contributionStatus = CRM_Utils_Array::value('contribution_status_id',$params,CRM_Utils_Array::value('contribution_status_id',$this->_defaultValues));
+            if( !empty($contributionStatus) && $contributionStatus == 2){
+              $this->assign('payment_outstanding',1);           
+            }
             require_once 'CRM/Core/BAO/MessageTemplates.php';
             list ($mailSend, $subject, $message, $html) = CRM_Core_BAO_MessageTemplates::sendTemplate(
                 array(
@@ -1465,8 +1468,7 @@
                 )
             );
         }
-       
-       
+
         if ( ( $this->_action & CRM_Core_Action::UPDATE ) ) {
             //end date can be modified by hooks, so if end date is set then use it.
             $endDate = ( $membership->end_date ) ? $membership->end_date : $endDate ;

Let's finish discussion on IRC today as the which approach so you can file an issue and commit patches to 4.1.