Author Topic: Member price sets & prefilled information (Read 4883 times)

mclyde · September 29, 2011, 09:42:00 pm

I am setting up member price sets and I noticed that if I edit the membership type, the membership price set does not automatically update the new option label (which is inherited from the membership type) unless one goes back to the price set and reclicks on the memberhip types

Also, the option label and price are taken from the membership type, but not the description field. It would be nice to have this pre-filled with the description (and delete if not needed) so that content is consistent.

(will see if I can find in the code where the forms are prefilled)

Dave Greenberg · September 30, 2011, 09:27:50 am

Merlise - Glad you are "exercising" the new feature!

I don't think we should be updating price set options (label and amount) automatically when membership type values are changed. One of the "features" of using the price sets for membership signup is that price set options can offer discounts / special offers which would have potentially a different label - e.g. "Student Membership (summer discount)" and cost.

I do think pre-filling the option description from membership type description when option is created would be useful.

mclyde · September 30, 2011, 06:16:28 pm

When the price set is first created it does inherit the values/labels from the membership type definition. E.g. I have a section membership used in a traditional membership page for my life members (who do not renew "national" dues) and then select the same membership type for the price set. Both are the same. If I change the label in the member type, the standard membership page reflects the change in labels while the price set does not. Ditto for the price. As a user my expectation is that if I define a membership type definition, that it should be reflected everywhere. If I want to offer a discounted membership, then I change the price once in the membership definition and any membership page that uses that type will have values that are consistent.

Will this cause problems with renewals or member summaries if there are two or more variants of the same membership type?

I discovered this by being confused because my labels were not being updated in the form.

cheers,
Merlise

Dave Greenberg · September 30, 2011, 08:39:02 pm

Hmm - I know that Eileen (and I think some others) wanted to use the price sets feature to offer temporary (and sometimes date driven) special offers w/o changing the underlying membership type fee or label. I guess there's a difference in requirements and expectations :-(

I do think that the current approach offers more flexibility. Let's see if others pipe in on one side of this or the other.

mclyde · September 30, 2011, 11:46:45 pm

But as far as I can tell there is no way for back office renewal using the price set, as the renew option uses the price in the membership type. (new memberships can be added but not renewals) leading two potentially two different prices for the same membership in the same time period.

Dave Greenberg · October 02, 2011, 07:01:25 pm

Price sets where not implemented for offline renewal because the UI didn't seem to make sense (admin clicks "renew" for a particular membership and is offered a multi-membership renewal - seemed confusing) - and we were quite a bit over funded scope already :-(

That said, the admin can adjust the actual fee charged when doing a renewal.

In any case, would be good if you could catch Eileen on IRC and talk this thru a bit.

Eileen · October 03, 2011, 12:40:48 pm

Hi,

I do feel that the site admin should be able to over-write the label - e.g. offering the a 'student price' on geographically based membership. It might make sense to automatically over-write the labels where they are the same as the membership type but not otherwise.

With regards to off-line renewals - it would be a nice extension if we can work towards the UI presenting a list of pricesets that include the chosen membership type & dropping out price options that relate to other types. It obviously was too much for this round.

It also occurred to me seeing the implementation that if we just extended it such that a price set option could be linked to a specific event (& disappeared if the event was full) we'd be well on the way to be able to buy an event reg & a membership from one page.

mclyde · October 03, 2011, 01:33:35 pm

If the "add: membership in the UI for back office checked to see if there were existing memberships and updated those records as a renewal, then it seems that the code for adding/updating price-set based memberships could be handled offline rather easily. (with price sets some memberships will be new while others will be renewals) Currently there is no way to offer any incentives or non-memberhip items via the back office unless all memberships are new memberships.

Since we have to enter up to 3 memberships/persons offline for members who sign up from our sister oganization, we would have to use a combination of renew or add to update the records (getting an import script to work is a future task :-), while a price set would provide a much simpler UI

I would be very supportive of adding membership + event signup together, if it could allow instant membership discounts!

mclyde · October 04, 2011, 01:21:53 pm

Is there any quick way to pre-fill the descriptions in price sets using the membership type description via a sql query (I am not looking forward to cutting and pasting 16+ descriptions :-)

or a place to edit the functions in civicrm to the code base? (If someone can point me to the right file I could take a look

TIA
Merlise

Eileen · October 04, 2011, 01:54:25 pm

Try this

UPDATE `civicrm_price_field_value` v LEFT JOIN civicrm_membership_type t on v.membership_type_id = t.id
SET v.description = t.description
WHERE t.id IS NOT NULL

mclyde · October 04, 2011, 04:20:52 pm

Thanks Eileen!

Course I just realized after setting up some that the descriptions are never displayed (at least on the test-drive page)

Is that intended?

cheers,
m

Dave Greenberg · October 04, 2011, 05:19:45 pm

For price set field options, the descriptions have only been used for internal reference (not displayed to the end users). I think the assumption is that option labels (plus field and set help) are sufficient, and it's not obvious how descriptions would be displayed given the range of html input types (select, checkbox etc.).

If you want to pull your membership type descriptions into the price field value (option) labels, you can adapt Eileen's query a bit. Something like:

Code: [Select]

UPDATE `civicrm_price_field_value`  v LEFT JOIN civicrm_membership_type t on v.membership_type_id = t.id
SET v.label = CONCAT( t.name, ' (', t.description, ')')
WHERE t.id IS NOT NULL;

mclyde · October 04, 2011, 06:24:44 pm

my current example (a subset actually)

* Regular 1-year $35
* Student 1 year $15
* Reduced rate 1 year $15
* Joint IMS/ISBA $112
* Life Membership $500

On the regular membership page the description is displayed underneath each label/price - so that would be ideal!

Adding the description to the label doesn't really work as they are too long (e.g. explanation for Reduced rate is
"Reduced rate for permanent residents of countries whose per capita GNP (as reported by World Bank) does not exceed $6,000/person"
<a href="/node/3" target="_blank"> Reduced 1-year</a>

Given the number of options I am worried that they would get lost in the help field. I have tried using hover option by using html in the label so that the description pops up when the mouse hovers over the text but that is not as obvious (diito for the link)

Dave Greenberg · October 05, 2011, 03:59:38 pm

That approach would not work for <select> style, but would for radio and checkbox. Are you up for submitting a patch to do that in 4.1?

mclyde · October 05, 2011, 06:11:45 pm

it will also only work if the number in line is set to one - so that may be too special a case for the general setting?

I did try adding a span tag in the option label so that the test appears with a mouse over and put some extra help in the body so that the section does look ok.

As for making a patch - I can try but I need someone to at least orient me in the right direction to identify which files are being used in the price sets :-) as I have not worked with building forms. Although if i tackle any coding it will be to try to prevent the Lifetime members from accidentally renewing...

best,
Merlise

CiviCRM Community Forums (archive)

News:

Author Topic: Member price sets & prefilled information (Read 4883 times)

mclyde

Member price sets & prefilled information

Dave Greenberg

Re: Member price sets & prefilled information

mclyde

Re: Member price sets & prefilled information

Dave Greenberg

Re: Member price sets & prefilled information

mclyde

Re: Member price sets & prefilled information

Dave Greenberg

Re: Member price sets & prefilled information

Eileen

Re: Member price sets & prefilled information

mclyde

Re: Member price sets & prefilled information

mclyde

Re: Member price sets & prefilled information

Eileen

Re: Member price sets & prefilled information

mclyde

Re: Member price sets & prefilled information

Dave Greenberg

Re: Member price sets & prefilled information

mclyde

Re: Member price sets & prefilled information

Dave Greenberg

Re: Member price sets & prefilled information

mclyde

Re: Member price sets & prefilled information