CiviCRM Community Forums (archive)

When groups are disabled, are they still used in the ACL checks? I have the impression they do.

I was having a performance issue on a site, more specifically in CiviMail, when at the second step civi calculates the number of recipients in the mailing. i.e. the ACL checks do 5 "left joins" on civicrm_group and mine has 160 000 entries in it.

After further inpsection, many of those tables being joined were for disabled groups.

So I tested changing CRM/ACL/BAO/ACL.php, in function whereClause, I added "AND g.is_active = 1" in the code (line 132 in my case, CiviCRM 3.4.5):

            if ( ! empty( $ids ) ) {
                $ids = implode( ',', $ids );
                $query = "
SELECT g.*
  FROM civicrm_group g
 WHERE g.id IN ( $ids )
 AND is_active = 1
";

This removed those disabled tables and solved a big part of my problem.

Is this correct? Should I open an issue for this?

Thanks for the quick feedback. I created the issue : http://issues.civicrm.org/jira/browse/CRM-8999