CiviCRM Community Forums (archive)

Hi,
Wanted to share this with everyone. We experienced this error message after conpleting an online contribution.
Error message: undefined index 'onbehalf' in .../civicrm/CRM/Contribute/Form/Contribution/Confirm.php, line 740
This was for a contribution page that did not have "Allow Individuals to make contributions on behalf of an Organization" box checked.

This was with Drupal 7.8 and Civicrm 4.0.4 (sorry did not have time to check this against 4.0.6).

To solve this issue we changed the following code (starting on line 740) from:
           if ( is_array( $paymentParams['onbehalf'] ) && !empty( $paymentParams['onbehalf'] ) ) {
                foreach ( $paymentParams['onbehalf'] as $key => $value ) {
                    if ( strstr( $key, 'custom_' ) ) {
                        $this->_params[$key] = $value;
                    }
                }
                $fieldTypes = array( 'Contact', 'Organization', 'Contribution' );
            }

to:
            if ( isset( $paymentParams['onbehalf'] ) ) {
            if ( is_array( $paymentParams['onbehalf'] ) && !empty( $paymentParams['onbehalf'] ) ) {
                foreach ( $paymentParams['onbehalf'] as $key => $value ) {
                    if ( strstr( $key, 'custom_' ) ) {
                        $this->_params[$key] = $value;
                    }
                }
                $fieldTypes = array( 'Contact', 'Organization', 'Contribution' );
            }
            }

Can someone check this against the latest code base and make sure this is covered and potentially create a patch for earier versions if necessary? I have not done a patch before so I am hoping someone more experienced can jump in.
I am also somewhat puzzled that I might be the first one to find/experience this so I wanted to share.

Regards, Thomas

I thought we were only hitting problems on the above for Contribs that were allowing 'on behalf of' but maybe you picked up and fixed this as part of the same deal?