CiviCRM Community Forums (archive)

On an earlier post I complained of having memory issues with civimail.cronjob.php - see http://forum.civicrm.org/index.php/topic,22211.msg93343.html

I've found the cause, and I have attached a patch. There's another issue, but I'm not sure how to resolve that.

Our CiviMail Mailing header includes the mailing.viewUrl token. During the processing of each email CRM_Mailing_BAO_Mailing::getTokenData() is called to process this token. Here's the code for mailing.* tokens ...
        } else if( $type == 'mailing' ) {
            require_once 'CRM/Mailing/BAO/Mailing.php';
            $mailing = new CRM_Mailing_BAO_Mailing( );
            $mailing->find( true );
            if ( $token == 'name' ) {
                $data = $mailing->name ;
            } else if ( $token == 'group' ) {
                $groups = $mailing->getGroupNames( );
                $data = implode(', ', $groups);
            }         
        } else {

The creating and populating of a new CRM_Mailing_BAO_Mailing has two issues ...

• When I use CRM_Utils_System::memory() it tells me that memory usage increases by 3Mb each time this is called. Commenting out the call resolves the memory issue.
• The find() call populates the CRM_Mailing_BAO_Mailing with the content of the first mailing - not this mailing. I suspect if I was using the mailing.name token I'd get a surprise!

I think the fix should be ...

• Only do a 'new' and a 'find' if they're needed - ie when the token is mailing.name or mailing.group
• Review whether 'new' and 'find' are actually needed - why not use $this rather than $mailing?

Ken

The code was added to trunk as r26463 as part of CRM-5058. The patch I attached was taken from the Drupal tar file for 3.4.7. Here it is again as a quote ...
--- /data/Download/CiviCRM/civicrm-3.4.7-drupal/./CRM/Mailing/BAO/Mailing.php 2011-08-23 20:28:46.000000000 +1000
+++ /data/Work/IT/CiviCRM/Local/3.4.7/php/./CRM/Mailing/BAO/Mailing.php 2011-11-19 14:35:57.574287583 +1100
@@ -1239,13 +1239,10 @@
             $domain =& CRM_Core_BAO_Domain::getDomain( );
             $data = CRM_Utils_Token::getDomainTokenReplacement($token, $domain, $html);
         } else if( $type == 'mailing') {
-            require_once 'CRM/Mailing/BAO/Mailing.php';
-            $mailing = new CRM_Mailing_BAO_Mailing( );
-            $mailing->find( true );
             if ( $token == 'name' ) {
-                $data = $mailing->name ;
+                $data = $this->name ;
             } else if ( $token == 'group' ) {
-                $groups = $mailing->getGroupNames( );
+                $groups = $this->getGroupNames( );
                 $data = implode(', ', $groups);
             }         
         } else {

I've tested that commenting out the 'new' and 'find' stop the memory leak. However, I'm not sure if changing '$mailing' to '$this' works, as I don't really understand the contexts in which this code is used.

Ken

Created issue CRM-9217