CiviCRM Community Forums (archive)

Hi,

The goal is to fix all that and have a test unit framework I don't think is hostile to me and hates me personally (and even if I'm the more vocal, that's a shared feeling). I'm trying to suggest solutions, not moaning for the sake of it.

Part of the problem is that it doesn't follow the same convention than the rest of civi and feels like a parasite stuck on it. Part is that it's not finished more below.

1) what's the point of having a user password that you can configure? I don't see any reason to force me to handle manually a user password and host if the database is hardcoded

Why isn't it simply stored in the civicrm.settings.php file that you have to configure anyway? and we skip the params and that's it.

2) All the rest runs from the root of svn, why should it be different for the tests?

3) in order to run the tests, I have to grant super to an unprotected account (that I need to put the password on the cli command). Ie. I see running tests as a security vulnerability.

The only place I accept having the "root" password is on a my.cfg that is well protected on a non production server.

What is the need for SUPER? I'm sure we can skip that requirement.

4) The syntax to run a test for a single file is unfriendly (having to type manually the class when you have the file name right in front of you)

THat might be a command line habbit in linux, but I tend to switch between vi blablafile.php and php blablafile.php with all the autocomplete tab goodies and history , that works ok

being able to run it with the name of the file as a param

or (dream solution) instead of having a script wrapper (that can be kept anyway)

being able to simply from svnroot

php tests/phpunit/api/v3/PhoneTest.php

changes to implement (?):

instead of
require_once 'CiviTest/CiviUnitTestCase.php';
having
require_once 'tests/phpunit/CiviTest/CiviUnitTestCase.php';

that would alter the include path and do the needed requires and init stuff if not done already


so we'd be able to to cycle between
vi api/v3/Phone.php
vi tests/phpunit/api/v3/PhoneTest.php
php tests/phpunit/api/v3/PhoneTest.php

would make me way less moaning.

In my ideal world I would be able to

$php tests/phpunit/api/v3/PhoneTest.php --no-init (that wouldn't re-init the db)
and
$php tests/phpunit/api/v3/PhoneTest.php testCreatePhone

Worthwhile investigating on my side or dead end?

X+

Thanks Tgr.

I was aware the feature exists, but I find the syntax hard to remember/type (compared to my suggested syntax)

1. I'm not very sure we should go down the path of hacking phpunit to use a syntax which seems easier to some

was more to wrap the syntax to transform it so it's seen by phpunit as it expecting it, don't want to hack it either.

As for the syntax, might be because I don't use test the normal way? I don't run all the suite, but only the test i'm working on. Is this how your work too?

2. if you have set your .my.cnf, u dont need to enter your username/pass/host of DB (check the wiki docs)

ah ok, nice, but it means you run the tests with your mysql account, right? (ie. if a test contains code that drop all the databases, that will destroy more than just the test db)

3. dont know about super privilege and why its needed. If u can track that down it would be great

Will do.

4. adding a shell wrapper script called: xaviersawesomewrapper.sh (or php) which does:
* cd to the scripts directory
* converts filename / shortname to what the framework expects
* adds the --filter if it detects wanting to test only one function
* any other issues that bug you

Is there a function that converts file to class already?


X+

That's nice, I like it. can you attach it here?

You could change the PHPUnit command line interpreter like this:

paste2.org/p/1822172

that will recognize test specifications in the format PhoneTest::testCreatePhone (which is the same format PHPUnit uses to report test results).

Implemented

$php tests/bin/api3.php [Entity] [Action]
and
$php tests/bin/run.php filetorun.php

http://issues.civicrm.org/jira/browse/CRM-9354

:-)