CiviCRM Community Forums (archive)

I'm excited about the new hook_tokenValues and being able to write some great efficient queries. One problem:
When I test using print pdf letter, instead of calling the hook once and giving each contact ID in an array, it calls the hook once per contact (with the $cids array containing just the one cid) which pretty much defeats the point of writing a nice query.

Good to know. I hope to work on that sometime. Optimizing it would be cool. I remember Eileen noted that she had to give up on PDF letters because it choked on just a few hundred contacts.

One more odd thing I noticed:

the hook_tokens() requires redundant names, like
$tokens['contact']['contact.address_format'] = 'Address Formatted'; // notice the unnecessary 'contact.' prefix

but the $tokens param sent in to hook_tokenValues then shows it as
$tokens['contact']['address_format'] // no redundant dot thingey

but to fill its value in hook_tokenValues, the dot thingey is needed:
$values[$cid]['contact.address_format'] = 'foo';

despite the fact that it's not there in existing values. Example of what $values looks like after I just added that value:
array(
  'contact_id' => 123
  'display_name' => 'Foo Bar',
  'contact.address_format' => 'foo',
);

Oddly inconsistent. but when I try just adding 'address_format' it don't work.

Interest, yes. Time, maybe. And the trouble with fixing hooks is that it also breaks them, for anyone who's already implemented it the "wrong" way.

yes, centralizing the token code in one place would also be good.

lobo