CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviEvent (Moderator: Yashodha Chaku) »
  • CiviDiscount Module Extension
Pages: 1 ... 5 6 [7] 8

Author Topic: CiviDiscount Module Extension  (Read 24794 times)

seb

  • I’m new here
  • *
  • Posts: 26
  • Karma: 1
  • CiviCRM version: 4.6.4
  • CMS version: Drupal 7/Drupal 8
  • MySQL version: Ver 14.14 Distrib 5.5.44, for debian-linux-gnu
  • PHP version: PHP 5.6.9-0+deb8u1
Re: CiviDiscount Module Extension
January 30, 2014, 10:28:37 am
Thanks, I've opened a ticket on github for that problem


Donald Lobo

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 15963
  • Karma: 470
    • CiviCRM site
  • CiviCRM version: 4.2+
  • CMS version: Drupal 7, Joomla 2.5+
  • MySQL version: 5.5.x
  • PHP version: 5.4.x
Re: CiviDiscount Module Extension
January 30, 2014, 10:30:11 am

hopefully you'll follow it up with a PR to fix the issue :)

That module is currently community maintained and bug fixed

thanx

lobo
A new CiviCRM Q&A resource needs YOUR help to get started. Visit our StackExchange proposed site, sign up and vote on 5 questions

Edd

  • I’m new here
  • *
  • Posts: 6
  • Karma: 1
  • CiviCRM version: 4.2
  • CMS version: Drupal 7
  • MySQL version: 5.x
  • PHP version: 5.x
Re: CiviDiscount Module Extension
October 03, 2014, 03:02:23 pm
Trying to find for download a CiviDiscount version compatible with CiviCRM 4.1.1.
Nothing here: https://civicrm.org/extensions/cividiscount-extension. Version 2.0 didn't work for me (blank screen Administer > CiviDiscount).
Ideas?
Cheers.

jsimonis

  • I post frequently
  • ***
  • Posts: 316
  • Karma: 4
    • Forward Support, Inc.
  • CiviCRM version: 4.4-4.5
  • CMS version: Drupal 7
  • MySQL version: 5.5.37-cll
  • PHP version: 5.3.29
Re: CiviDiscount Module Extension
October 07, 2014, 12:15:57 am
This lists one for 1.0: https://civicrm.org/extensions/1671/releases

Wes Reimer

  • I post occasionally
  • **
  • Posts: 49
  • Karma: 1
  • CiviCRM version: 4.4.6
  • CMS version: WordPress 3.9.x
  • MySQL version: 5.5.36-cll
  • PHP version: 5.3.27
Re: CiviDiscount Module Extension
October 08, 2014, 02:16:19 pm
Edd, it doesn't work for me either in WP + 4.4.6. Same problem: Administer > CiviDiscount goes nowhere (returns to the Dashboard). I'll see if there's anything in Issue Tracker.
« Last Edit: October 08, 2014, 02:18:20 pm by Wes Reimer »

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: CiviDiscount Module Extension
October 08, 2014, 02:31:11 pm
We are using CiviDiscount fine on 4.4.7 in drupal - albeit a fork - https://github.com/eileenmcnaughton/org.civicrm.module.cividiscount/ - I developed a bunch of stuff on this fork - which got merged into the 4.5 version not the 4.4 version so this branch is more or less the 4.5 version for 4.4

Note that it makes DB changes (as does the 4.5 version) so don't put it on a live site without testing
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Wes Reimer

  • I post occasionally
  • **
  • Posts: 49
  • Karma: 1
  • CiviCRM version: 4.4.6
  • CMS version: WordPress 3.9.x
  • MySQL version: 5.5.36-cll
  • PHP version: 5.3.27
Re: CiviDiscount Module Extension
October 08, 2014, 06:43:51 pm
Thank you Eileen.

Just to clarify: it sounds like CiviDiscount is considered part of the core, at least from a coding point of view? It's the version numbers that are confusing me. The extension is at version 2.5, but your branch makes it work in core 4.4 and 4.5?

Also, you're saying that the branch makes DB changes, but the original extension doesn't? Or it makes different changes?

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: CiviDiscount Module Extension
October 08, 2014, 06:49:06 pm
I made a bunch of changes to the 4.4 version including DB changes (to the cividiscount tables) and did a PR against the 4.4 version. The PR was merged into the 4.5 version not the 4.4 version.

Since I had done that work in order to be able to support a much wider range of discounting on 4.4 I couldn't use that & continued with my own branch / fork. I made my branch / fork work with both 4.4 & 4.5 - mostly for dev reasons ( sacrificing the disable toggle in 4.4 to facilitate the same code to work easily against both was not a problem to me)

Once we get customers upgrading to 4.5 or 4.6 I hope to switch back to using the stock version.
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

jsimonis

  • I post frequently
  • ***
  • Posts: 316
  • Karma: 4
    • Forward Support, Inc.
  • CiviCRM version: 4.4-4.5
  • CMS version: Drupal 7
  • MySQL version: 5.5.37-cll
  • PHP version: 5.3.29
Re: CiviDiscount Module Extension
October 10, 2014, 01:58:12 am
Quote from: Wes Reimer on October 08, 2014, 02:16:19 pm
Edd, it doesn't work for me either in WP + 4.4.6. Same problem: Administer > CiviDiscount goes nowhere (returns to the Dashboard). I'll see if there's anything in Issue Tracker.

Mine did that as well. I had to go and clear out my Civi cache and then it worked.

Upperholme

  • Administrator
  • Ask me questions
  • *****
  • Posts: 568
  • Karma: 8
    • MC3
  • CiviCRM version: 4.x
  • CMS version: Drupal 6.x/7.x, Wordpress, Joomla
Re: CiviDiscount Module Extension
November 27, 2014, 08:24:56 am
I've been using the Cividiscount extension for a while now on a D6 site, and found out pretty early on that - for event registrations at least - it only worked if a price set was set up. No price set and Cividiscount simply didn't work. i thought it was down to using D6 and never even bothered to put up a forum post to report as I'd assumed I'd just get one of those "this is community supported code so sort it out yourself" messages.

Now I've just implemented version 2.6 of Cividiscount into a D7 site running Civi 4.4.6, and tried to use discount codes on a standard membership. Guess what? It only works if using a price set. Seems to be a trend. As this is a D7 install it seems reasonable to report it here. I see that there is a more recent version of Cividiscount so maybe this issue has been fixed in that, but I don't see upgrading as an option, presumably the new version is not compatible with 4.4.x

UPDATE: A bit more on this. I've noticed that by converting my price into a price set, the discount coder works, even though I've not selected the price set in my code setup. Odd. And where previously the usage appeared to be getting recorded correctly, that's now no longer working.

[Aside] Having one forum thread as the "official" location for support and issues seems a tad weird, don't you think?

« Last Edit: November 27, 2014, 09:28:19 am by Upperholme »
Graham Mitchell
http://mc3.coop

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: CiviDiscount Module Extension
November 27, 2014, 11:19:04 am
The version I use for CiviDiscount is here https://github.com/eileenmcnaughton/org.civicrm.module.cividiscount/ - you might try it. It is the basis for a bunch of changes that are in the 4.5 version but they weren't merged into 4.4 - only 4.5 - so I only use this version on 4.4 & will test the 4.5 version before I upgrade to it.

You can give it a  go but it DOES make DB changes - so test on a test site first
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Upperholme

  • Administrator
  • Ask me questions
  • *****
  • Posts: 568
  • Karma: 8
    • MC3
  • CiviCRM version: 4.x
  • CMS version: Drupal 6.x/7.x, Wordpress, Joomla
Re: CiviDiscount Module Extension
November 28, 2014, 05:08:56 am
Many thanks Eileen.

It will be good to get these two versions merged back into one. Information and support mechanisms for extensions are confusing enough as it is for end users.

Best wishes
Graham
Graham Mitchell
http://mc3.coop

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: CiviDiscount Module Extension
November 28, 2014, 01:08:23 pm
Well I originally re-worked the 4.4 version but core & forked for 4.5, added 4.5 specific code leaving the 4.4 changes only in my repo - I am not sure whether they are exactly the same but I hope to not be forked once we update to 4.6
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

manfredwoodall

  • I’m new here
  • *
  • Posts: 15
  • Karma: 0
  • CiviCRM version: 4.5.4
  • CMS version: Wordpress 4.0.1
  • MySQL version: 5.5.xx
  • PHP version: 5.3.18
Re: CiviDiscount Module Extension
December 05, 2014, 09:00:49 am
Hey there I'm currently working with a Development site testing the upgraded Wordpress and CiviCRM.

The site is running WP 4.0.1 and CiviCRM 4.5.4 We have also updated the Discount Module, but it now throughs the following error:

Warning: array_keys() expects parameter 1 to be array, null given in /usr/home/gbapgh/public_html/dev-site/go-gba/wp-content/plugins/files/civicrm/custom_ext/org.civicrm.module.cividiscount/CRM/CiviDiscount/DiscountCalculator.php on line 114

Warning: Invalid argument supplied for foreach() in /usr/home/gbapgh/public_html/dev-site/go-gba/wp-content/plugins/files/civicrm/custom_ext/org.civicrm.module.cividiscount/CRM/CiviDiscount/DiscountCalculator.php on line 114

This appears in the Memberships > New Membership page. It also appears to have disabled the "Add Membership" screen in the Contact Record.

Suggestions?

groston

  • I post occasionally
  • **
  • Posts: 61
  • Karma: 0
  • CiviCRM version: 4.5.5
  • CMS version: Drupal 7.34
  • MySQL version: 5.5.34
  • PHP version: 5.3.27
Re: CiviDiscount Module Extension
January 12, 2015, 08:09:51 am
All,

My D7 site is currently running CiviCRM 4.5.2 (I might consider updating later this week) and CiviDiscount 2.5 to provide a fixed discount to those who enter the magic code. Our model is simple - no price sets involved. When I first installed this under CiviCRM 4.4.x, it worked fine.

As noted below by several people, when I select Administration->CiviDiscount, the site goes nowhere (returns to the Dashboard). Per Eileen's post, I updated to CiviDiscount 2.5.1, and per jsimonis's post, I cleared the cache. Still not working.

Should I update to V2.6? If so, can someone please provide a pointer.
Pages: 1 ... 5 6 [7] 8
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviEvent (Moderator: Yashodha Chaku) »
  • CiviDiscount Module Extension

This forum was archived on 2017-11-26.