CiviCRM Community Forums (archive)

When I try to add a contribution (with 'Contribution Type' as 'Donation' and 'Paid By' as 'Cash' or 'Check'), I get the following error messages:

Please correct the following errors in the form fields below:
Bank/Building Society is a required field.
Name(s) of account holder(s) is a required field.
Bank/Building Society account number is a required field.
Sort Code is a required field.

There are no such fields on the form (at /civicrm/contact/view/contribution ), which makes sense as they're not needed for 'Cash' or 'Check' donations.

I've tested this on demo.civicrm.org and the same problem doesn't occur. In fact I could have sworn it didn't use to occur on our install...

These are fields which are added by civicrm_direct_debit.module (see http://civicrm.org/blogs/paul/civicrm-direct-debit-integration-uk ). However, they are not and should not be added to new contribution forms, but only to new membership forms, where I can indeed see them.

Even more mysteriously, I tried to track down the error with the following results:

1) Searched for a string from the error, 'equired fie', getting the results below:

cd drupalroot/sites/all/modules/civicrm_direct_debit]
grep -nr 'equired fie' .
./CRM/Contribute/Form/Contribution/Main.php:529:                    $this->addRule( 'amount', ts('%1 is a required field.', array(1 => ts('Amount'))), 'required' );
./CRM/Contribute/Form/Contribution/Main.php:538:                    $this->addRule( 'amount_other', ts('%1 is a required field.', array(1 => $title)), 'required' );
./CRM/Contribute/Form/Contribution/Main.php:553:                    $this->addRule( 'amount', ts('%1 is a required field.', array(1 => ts('Amount'))), 'required' );
./CRM/Contribute/Form/Contribution/Main.php:895:                    $errors['amount_other'] = ts('Amount is required field.');
./CRM/Contribute/Form/Contribution/Main.php:942:                        $errors['pledge_installments'] = ts( 'Pledge Installments is required field.' );
./CRM/Contribute/Form/Contribution/Main.php:955:                        $errors['pledge_frequency_interval'] = ts( 'Pledge Frequency Interval. is required field.' );
./CRM/Contribute/Form/Contribution/Main.php:978:               # $errors[$name] = ts( '%1 is a required field.', array( 1 => $fld['title'] ) );
./CRM/Contribute/Form/Contribution/Main.php:1004:                    $errors[$customizedGreeting] = ts( 'Custom %1 is a required field if %1 is of type Customized.',
./CRM/Contribute/Form/Contribution/Main.php~:529:                    $this->addRule( 'amount', ts('%1 is a required field.', array(1 => ts('Amount'))), 'required' );
./CRM/Contribute/Form/Contribution/Main.php~:538:                    $this->addRule( 'amount_other', ts('%1 is a required field.', array(1 => $title)), 'required' );
./CRM/Contribute/Form/Contribution/Main.php~:553:                    $this->addRule( 'amount', ts('%1 is a required field.', array(1 => ts('Amount'))), 'required' );
./CRM/Contribute/Form/Contribution/Main.php~:895:                    $errors['amount_other'] = ts('Amount is required field.');
./CRM/Contribute/Form/Contribution/Main.php~:942:                        $errors['pledge_installments'] = ts( 'Pledge Installments is required field.' );
./CRM/Contribute/Form/Contribution/Main.php~:955:                        $errors['pledge_frequency_interval'] = ts( 'Pledge Frequency Interval. is required field.' );
./CRM/Contribute/Form/Contribution/Main.php~:978:                $errors[$name] = ts( '%1 is a required field.', array( 1 => $fld['title'] ) );
./CRM/Contribute/Form/Contribution/Main.php~:1004:                    $errors[$customizedGreeting] = ts( 'Custom %1 is a required field if %1 is of type Customized.',
./civicrm_direct_debit.module:212:                $errors['sort_code_part_1'] = 'Sort Code is a required field.';
./civicrm_direct_debit.module:213:                $form->assign('SortCodeError' , 'Sort Code is a required field.');
./civicrm_direct_debit.module~:212:                $errors['sort_code_part_1'] = 'Sort Code is a required field.';
./civicrm_direct_debit.module~:213:                $form->assign('SortCodeError' , 'Sort Code is a required field.');
./civicrm_direct_debit.module.orig:212:                $errors['sort_code_part_1'] = 'Sort Code is a required field.';
./civicrm_direct_debit.module.orig:213:                $form->assign('SortCodeError' , 'Sort Code is a required field.');

2) Added lines to all these places to log if they were executed
3) Saw from my log that only ./civicrm_direct_debit.module.orig:212 got executed
4) Commented out the contents on the function containing that line and still got the error 'Bank/Building Society is a required field' as described in my OP.