CiviCRM Community Forums (archive)

I noticed a problem in 4.1.3 that may represent a lot of broken code.

I noticed that token replacement worked in the Text part of a Scheduled Reminder Email but not the HTML part. See http://forum.civicrm.org/index.php/topic,25025.0.html

I've tracked that down to a change in line 162 of CRM/Utils/Token.php. This change was made as part of r40475 which is a code reformatting change.

My concern is that this might be a symptom of a wide set of unintended changes that will cause all sorts of random havoc.

Here's the change...
-        return preg_match("/(^|[^\{])$token/", $str);
+    return preg_match("/(^|[^\{]) $token/", $str);
Note that the indentation has been fixed (good) but a space has been inserted into the regular expression (bad).

I'm assuming this is not an intended consequence of implementing a coding standard.

I suggest this needs an urgent review,

Ken

BTW I notice the fix for http://issues.civicrm.org/jira/browse/CRM-10389 is due to a similar problem where a PHP string was modified by the code formatter. (The string was Javascript code.)

filed and fixed here:

http://issues.civicrm.org/jira/browse/CRM-10431

lobo

grep is your friend

i restricted my search to all preg_* functions

lobo