CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site

This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Profiles (Moderator: Dave Greenberg) »
  • System messages when subscribing to a group
Pages: [1]

Author Topic: System messages when subscribing to a group  (Read 931 times)

Katy J

  • I post occasionally
  • **
  • Posts: 50
  • Karma: 4
    • Third Sector Design
System messages when subscribing to a group
November 12, 2012, 06:45:24 am
I have a profile being used to as a mailing list sign up form. It gathers name, email and country and then automatically adds anyone who fills it in to the group 'Newsletter'. Anyone who fills it in sees the same message on the next page "Thank you. Your information has been saved".

If the person has already signed up, but never activated their membership via the link they were emailed, they will also see the message "You are already subscribed in X, your subscription is pending".  It seems to me that if someone has a pending membership to this group, it may be that they signed up months ago, the message went to their spam and has long been deleted - is there anyway to give that person the chance to re-subscribe? I think there should be :) I think that the same email, with the confirmation link should be resent and these people should see the same message - "Thank you, please check your email..." type thing.

If we are unable to resend the email for some reason, then we should make it clearer to the end user what the situation is. The wording could be something like 'You have already subscribed to X, please check your email so that you can follow the link to confirm your subscription - be sure to check your spam/junkmail folders if you can't see it", but as I said - that email may be long gone, so much better to resend it.

Finally, I think the fact that this pending message is shown alongside the "Thank you. Your information has been saved" message is confusing for people. In fact, as far as I can see, that thank you message doesn't really need to show in any case.

A secondary but related point is that if you are already actually subscribed to the group you see the "Thank you. Your information has been saved" message, and nothing telling you that you are already a member (maybe - "...and if you're not getting the emails, please be sure to check your junk...") - am I missing this somewhere? Would this be easy to implement?

Happy to help with this if I can, just putting it out there for discussion first...
« Last Edit: November 13, 2012, 02:59:05 am by Katy J »
Do what you love, it's your gift to the universe

Deepak Srivastava

  • Ask me questions
  • ****
  • Posts: 677
  • Karma: 65
Re: System messages when subscribing to a group
November 14, 2012, 01:12:46 am
For profiles "Thank you. Your information has been saved" message is very generic. It displays it without knowing what purpose / context the profile is being used for. Given the variety of purpose profiles are used for we could come out with a better generic message.

The above default message is separate from subscription messages which is part of intermediate process, which is why subscription message is shown alongside the default message.

So problem could be split into two parts :

1. Fixing subscription code to show right message w.r.t pending status + allow re-sending mails.

The code is here CRM_Mailing_Event_BAO_Subscribe::commonSubscribe().
Currently for pending case code just displays the message and quits, and doesn't try to re-send the mail. Code will require some tweaking here to achieve this.

2. Making profile aware of intermediate generated messages (above case for example) and suppress showing default thank-you message.

The code where default message is shown - CRM/Profile/Form/Edit::postProcess() method.
Found this reply helpful? Contribute NOW and help us improve CiviCRM with the Make it Happen! initiative.

Katy J

  • I post occasionally
  • **
  • Posts: 50
  • Karma: 4
    • Third Sector Design
Re: System messages when subscribing to a group
November 14, 2012, 01:39:58 am
Thanks Deepak, agree with what you say.

I have one thing to add to the first part:

1.  Fixing subscription code to show right message w.r.t pending status + allow re-sending mails. Also, if you are already subscribed to this group - a notification of this.

I'm not equipped with the skills to take on playing about with the code myself, so can't offer to fix. Deepak, what's the best option - leave this post up and see what happens? Or file an improvement on Jira?
Do what you love, it's your gift to the universe

Deepak Srivastava

  • Ask me questions
  • ****
  • Posts: 677
  • Karma: 65
Re: System messages when subscribing to a group
November 14, 2012, 02:35:11 am
What we could do now is improve the pending status message, like the one you suggested - "You have already subscribed to X, please check your email so that you can follow the link to confirm your subscription - be sure to check your spam/junkmail folders if you can't see it". You could file issue for this.

For "re-sending mailing" and "profile suppressing default thank-you message" - i would say lets wait for more inputs / discussions, unless there is a patch already.
Found this reply helpful? Contribute NOW and help us improve CiviCRM with the Make it Happen! initiative.

Katy J

  • I post occasionally
  • **
  • Posts: 50
  • Karma: 4
    • Third Sector Design
Re: System messages when subscribing to a group
November 14, 2012, 04:12:44 am
Agreed. For this site I'm working on, I've changed the civi message to just 'Thank you.' in CRM/Profile/Form/Edit.php line 271.

I have also overridden the styles in my Civi theme to make the non-generic message stand out more (bigger font size, more padding, wider border)

I think that from a user perspective, it's unnecessary and confusing to see 2 messages. Are there any cases in which we actually need to display the default one, or is it always accompanied by another one? Maybe we can just get rid of it?

And again, the fact that there is no - "You are already subscribed to this group" message is something that, IMO, needs addressing reasonably urgently.

I heard Coleman was doing work on messages recently, so this may be of interest to him...?
« Last Edit: November 14, 2012, 04:15:36 am by Katy J »
Do what you love, it's your gift to the universe

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: System messages when subscribing to a group
November 20, 2012, 04:07:56 pm
So far the work I've done on messages has been back-end only. But it seems like it might be desirable to let that "Thank you your stuff has been saved" string be configurable per-profile.
Try asking your question on the new CiviCRM help site.

Michael McAndrew

  • Forum Godess / God
  • I live on this forum
  • *****
  • Posts: 1274
  • Karma: 55
    • Third Sector Design
  • CiviCRM version: various
  • CMS version: Nearly always Drupal
  • MySQL version: 5.5
  • PHP version: 5.3
Re: System messages when subscribing to a group
November 21, 2012, 01:29:52 am
Quote
So far the work I've done on messages has been back-end only

Hey there, by back end only do you mean, you have only worked on messages that get shown by CiviCRM.  How about messages that we pass to drupal_set_message().  Is there a rule for when we use one or the other?  I think that in this case the problem is that we display a drupal message and a civicrm message on the same screen which doesn't make sense IMO.

I haven't investigated why this is the case, but I wonder if it is simple as something like 'if this is a public page, we should route all messages to the CMS message displayer'

Michael
Service providers: Grow your business, build your reputation and support CiviCRM. Become a partner today

Coleman Watts

  • Administrator
  • I’m (like) Lobo ;)
  • *****
  • Posts: 2346
  • Karma: 183
  • CiviCRM version: The Bleeding Edge
  • CMS version: Various
Re: System messages when subscribing to a group
November 21, 2012, 07:08:28 am
Quote
if this is a public page, we should route all messages to the CMS message displayer

That sounds right-on to me.
Try asking your question on the new CiviCRM help site.

Pages: [1]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using Profiles (Moderator: Dave Greenberg) »
  • System messages when subscribing to a group

This forum was archived on 2017-11-26.