CiviCRM Community Forums (archive)

Hi All!

I'm running into some trouble setting up premiums on the contribution page I'm building for membership sign-up and renewal.  I was hoping you could help me figure out whether this is a bug caused by me screwing up somewhere in installation/configuration, or just functionality that didn't exist way back in 4.1.

Premiums work beautifully on my contribution pages that manage giving levels through the "Contribution Amounts" section, restricting the choice of premium based on whether the contribution level meets the minimum amount.  But when I set up giving levels through "Membership Price sets", Civi has no problem approving the $500 premium for a member renewing at $12.

My payment processor is Stripe, and I'm running 4.1 in Drupal.  Is something wrong, or do I just need to upgrade to get the functionality I'm describing?  Thank you so much!

Here is the solution for CiviCRM 4.2.  I'm not sure if this problem still exists in 4.3 or existed in 4.1, but the issue is that the code was checking to see if the "Amounts Block" was enable in the contribution form, and if it was not enabled then it didn't check the premium minimum donation.

So if you're using a price set--or just a membership level with no Amounts Block enabled--your users could select any premium at all.

The fix is in CRM/Contribute/Form/Contribution/Main.php around line 998:

Original:
    if (isset($fields['selectProduct']) &&
      $fields['selectProduct'] != 'no_thanks' &&
      $self->_values['amount_block_is_active']
    ) {
      $productDAO = new CRM_Contribute_DAO_Product();
      $productDAO->id = $fields['selectProduct'];
      $productDAO->find(TRUE);
      $min_amount = $productDAO->min_contribution;

Fixed:
    if (isset($fields['selectProduct']) &&
      $fields['selectProduct'] != 'no_thanks'
      //&& $self->_values['amount_block_is_active']
    ) {
      $productDAO = new CRM_Contribute_DAO_Product();
      $productDAO->id = $fields['selectProduct'];
      $productDAO->find(TRUE);
      $min_amount = $productDAO->min_contribution;

I haven't tested this super-extensively but it should work.  If you've selected a premium other than 'no thanks' it should always check the minimum premium against your total, and that is what the code above does.