CiviCRM Community Forums (archive)

Hi,

This PHP error observed in large quantities on mailing reports on a 4.2.6 site, e.g. Mailing Detail Report
/civicrm/report/instance/28?reset=1&mailing_id_value=375&is_optout_value=1

mysql_real_escape_string(): Access denied for user ''@'localhost' (using password: NO) in .../civicrm/CRM/Mailing/BAO/Mailing.php on line 2641.
mysql_real_escape_string(): A link to the server could not be established in .../civicrm/CRM/Mailing/BAO/Mailing.php on line 2641.

The relevant code:

      $query = "
SELECT civicrm_mailing.id, civicrm_mailing.name, civicrm_mailing_job.end_date
FROM   civicrm_mailing
INNER JOIN civicrm_mailing_job ON civicrm_mailing.id = civicrm_mailing_job.mailing_id {$where}
ORDER BY civicrm_mailing.name";
      $mailing = CRM_Core_DAO::executeQuery($query);

      while ($mailing->fetch()) {
        $list[mysql_real_escape_string($mailing->id)] = "{$mailing->name} :: {$mailing->end_date}";
      }

mysql_real_escape_string() connects to db to get the current character set of the connection. "If the link identifier is not specified, the last link opened by mysql_connect() is assumed. If no such link is found, it will try to create one as if mysql_connect() was called with no arguments." Hence the "Access denied for user ''@'localhost'". I'm not clear why it's unable to find the last link opened by mysql_connect(). Possibly because CIVICRM_DSN specifies mysqli?

In any case, I don't see why mysql_real_escape_string() is needed here as the code isn't preparing a db query. And $mailing->id is an integer. Changing to addslashes() gets rid of the error.

Dave J

pretty sure we dont need either mysql_real_escape_string or addslashes

so i got rid of it for 4.3

lobo